Skip to content

Commit f7fc9de

Browse files
committed
remove old assertion and improve tests
1 parent c8d814d commit f7fc9de

File tree

1 file changed

+7
-20
lines changed

1 file changed

+7
-20
lines changed

kubernetes/e2e_test/test_client.py

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -532,35 +532,22 @@ def test_configmap_apis(self):
532532
name=name, namespace='default')
533533
self.assertEqual(name, resp.metadata.name)
534534

535-
test_configmap['data']['config.json'] = "{}"
536-
resp = api.patch_namespaced_config_map(
537-
name=name, namespace='default', body=test_configmap)
538-
539535
json_patch_name = "json_patch_name"
540-
json_patch_body = [
541-
{
542-
"op": "replace",
543-
"path": "/data",
544-
"value": {
545-
"new_value": json_patch_name,
546-
"config.json": "{\"command\":\"/usr/bin/mysqld_safe\"}",
547-
"frontend.cnf": "[mysqld]\nbind-address = 10.0.0.3\nport = 3306\n"
548-
}
549-
}
550-
]
536+
json_patch_body = [{"op": "replace", "path": "/data",
537+
"value": {"new_value": json_patch_name}}]
551538
resp = api.patch_namespaced_config_map(
552539
name=name, namespace='default', body=json_patch_body)
553540
self.assertEqual(json_patch_name, resp.data["new_value"])
541+
self.assertEqual(None, resp.data.get("config.json"))
542+
self.assertEqual(None, resp.data.get("frontend.cnf"))
554543

555544
merge_patch_name = "merge_patch_name"
556-
merge_patch_body = {"data": {
557-
"new_value": merge_patch_name,
558-
"config.json": "{\"command\":\"/usr/bin/mysqld_safe\"}",
559-
"frontend.cnf": "[mysqld]\nbind-address = 10.0.0.3\nport = 3306\n"
560-
}}
545+
merge_patch_body = {"data": {"new_value": merge_patch_name}}
561546
resp = api.patch_namespaced_config_map(
562547
name=name, namespace='default', body=merge_patch_body)
563548
self.assertEqual(merge_patch_name, resp.data["new_value"])
549+
self.assertEqual(None, resp.data.get("config.json"))
550+
self.assertEqual(None, resp.data.get("frontend.cnf"))
564551

565552
resp = api.delete_namespaced_config_map(
566553
name=name, body={}, namespace='default')

0 commit comments

Comments
 (0)