Skip to content

Commit cef5e9b

Browse files
authored
Merge pull request #1155 from MoShitrit/fix-issue-967
Update Examples to stop using deprecated versions
2 parents d63282e + 6e62c3d commit cef5e9b

File tree

2 files changed

+9
-75
lines changed

2 files changed

+9
-75
lines changed

examples/notebooks/create_deployment.ipynb

Lines changed: 6 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"outputs": [],
4848
"source": [
4949
"config.load_kube_config()\n",
50-
"apps_api = client.AppsV1beta1Api()"
50+
"apps_api = client.AppsV1Api()"
5151
]
5252
},
5353
{
@@ -70,7 +70,7 @@
7070
},
7171
"outputs": [],
7272
"source": [
73-
"deployment = client.AppsV1beta1Deployment()"
73+
"deployment = client.V1Deployment()"
7474
]
7575
},
7676
{
@@ -93,7 +93,7 @@
9393
},
9494
"outputs": [],
9595
"source": [
96-
"deployment.api_version = \"apps/v1beta1\"\n",
96+
"deployment.api_version = \"apps/v1\"\n",
9797
"deployment.kind = \"Deployment\"\n",
9898
"deployment.metadata = client.V1ObjectMeta(name=\"nginx-deployment\")"
9999
]
@@ -118,7 +118,7 @@
118118
},
119119
"outputs": [],
120120
"source": [
121-
"spec = client.AppsV1beta1DeploymentSpec()\n",
121+
"spec = client.V1DeploymentSpec()\n",
122122
"spec.replicas = 3"
123123
]
124124
},
@@ -258,62 +258,7 @@
258258
},
259259
{
260260
"cell_type": "markdown",
261-
"metadata": {
262-
"deletable": true,
263-
"editable": true
264-
},
265-
"source": [
266-
"### Create DeploymentRollback object\n",
267-
"This object is used to rollback to a previous version of the deployment."
268-
]
269-
},
270-
{
271-
"cell_type": "code",
272-
"execution_count": null,
273-
"metadata": {
274-
"collapsed": true,
275-
"deletable": true,
276-
"editable": true
277-
},
278-
"outputs": [],
279-
"source": [
280-
"rollback = client.AppsV1beta1DeploymentRollback()\n",
281-
"rollback.api_version = \"apps/v1beta1\"\n",
282-
"rollback.kind = \"DeploymentRollback\"\n",
283-
"rollback.rollback_to = client.AppsV1beta1RollbackConfig()\n",
284-
"rollback.rollback_to.revision = 0\n",
285-
"rollback.name = \"nginx-deployment\""
286-
]
287-
},
288-
{
289-
"cell_type": "markdown",
290-
"metadata": {
291-
"deletable": true,
292-
"editable": true
293-
},
294-
"source": [
295-
"### Execute RollBack"
296-
]
297-
},
298-
{
299-
"cell_type": "code",
300-
"execution_count": null,
301-
"metadata": {
302-
"collapsed": false,
303-
"deletable": true,
304-
"editable": true
305-
},
306-
"outputs": [],
307-
"source": [
308-
"extension.create_namespaced_deployment_rollback_rollback(name=\"nginx-deployment\", namespace=\"default\", body=rollback)"
309-
]
310-
},
311-
{
312-
"cell_type": "markdown",
313-
"metadata": {
314-
"deletable": true,
315-
"editable": true
316-
},
261+
"metadata": {},
317262
"source": [
318263
"### Delete Deployment"
319264
]
@@ -328,19 +273,8 @@
328273
},
329274
"outputs": [],
330275
"source": [
331-
"extension.delete_namespaced_deployment(name=\"nginx-deployment\", namespace=\"default\", body=client.V1DeleteOptions(propagation_policy=\"Foreground\", grace_period_seconds=5))"
276+
"apps_api.delete_namespaced_deployment(name=\"nginx-deployment\", namespace=\"default\", body=client.V1DeleteOptions(propagation_policy=\"Foreground\", grace_period_seconds=5))"
332277
]
333-
},
334-
{
335-
"cell_type": "code",
336-
"execution_count": null,
337-
"metadata": {
338-
"collapsed": true,
339-
"deletable": true,
340-
"editable": true
341-
},
342-
"outputs": [],
343-
"source": []
344278
}
345279
],
346280
"metadata": {

examples/notebooks/intro_notebook.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@
8989
},
9090
"outputs": [],
9191
"source": [
92-
"api_instance = client.AppsV1beta1Api()\n",
93-
"dep = client.AppsV1beta1Deployment()\n",
94-
"spec = client.AppsV1beta1DeploymentSpec()"
92+
"api_instance = client.AppsV1Api()\n",
93+
"dep = client.V1Deployment()\n",
94+
"spec = client.V1DeploymentSpec()"
9595
]
9696
},
9797
{

0 commit comments

Comments
 (0)