Skip to content

Commit c1249c9

Browse files
committed
Support both python 2.7 and 3.x.
1 parent d9ec734 commit c1249c9

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

examples/pod_portforward.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
import select
2020
import socket
2121
import time
22-
import urllib.request
22+
23+
import six.moves.urllib.request as urllib_request
2324

2425
from kubernetes import config
2526
from kubernetes.client import Configuration
@@ -179,11 +180,11 @@ def kubernetes_create_connection(address, *args, **kwargs):
179180

180181
# Access the nginx http server using the
181182
# "<pod-name>.pod.<namespace>.kubernetes" dns name.
182-
response = urllib.request.urlopen(
183+
response = urllib_request.urlopen(
183184
'http://%s.pod.default.kubernetes' % name)
184185
html = response.read().decode('utf-8')
185186
response.close()
186-
print('Status:', response.status)
187+
print('Status Code: %s' % response.code)
187188
print(html)
188189

189190

kubernetes/e2e_test/test_client.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import socket
1818
import time
1919
import unittest
20-
import urllib.request
2120
import uuid
2221

2322
from kubernetes.client import api_client
@@ -26,6 +25,7 @@
2625
from kubernetes.stream import stream, portforward
2726
from kubernetes.stream.ws_client import ERROR_CHANNEL
2827

28+
import six.moves.urllib.request as urllib_request
2929

3030
def short_uuid():
3131
id = str(uuid.uuid4())
@@ -228,7 +228,7 @@ def test_portforward_raw(self):
228228
self.assertTrue(pf.connected)
229229

230230
sock = pf.socket(1236)
231-
self.assertRaises(BrokenPipeError, sock.sendall, b'This should fail...')
231+
self.assertRaises(socket.error, sock.sendall, b'This should fail...')
232232
self.assertIsNotNone(pf.error(1236))
233233
sock.close()
234234

@@ -246,6 +246,7 @@ def test_portforward_raw(self):
246246
reply += data
247247
self.assertEqual(reply, sent)
248248
sock.close()
249+
time.sleep(1)
249250
self.assertFalse(pf.connected)
250251
self.assertIsNone(pf.error(1234))
251252
self.assertIsNone(pf.error(1235))
@@ -300,12 +301,12 @@ def kubernetes_create_connection(address, *args, **kwargs):
300301
socket_create_connection = socket.create_connection
301302
try:
302303
socket.create_connection = kubernetes_create_connection
303-
response = urllib.request.urlopen('http://%s.default.kubernetes/' % name)
304+
response = urllib_request.urlopen('http://%s.default.kubernetes/' % name)
304305
html = response.read().decode('utf-8')
305306
finally:
306307
socket.create_connection = socket_create_connection
307308

308-
self.assertEqual(response.status, 200)
309+
self.assertEqual(response.code, 200)
309310
self.assertTrue('<h1>Welcome to nginx!</h1>' in html)
310311

311312
resp = api.delete_namespaced_pod(name=name, body={},

0 commit comments

Comments
 (0)