Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Commit 8645637

Browse files
committed
config: Fix persist_config flag and function calls
The persist_config flag was setting the kwargs['config_persister'] to the result of the function kcfg.save_changes and not the function kcfg.save_changes itself. Once this is fixed, the second problem was that the function was called with an argument when it's defined without argument so an exception was raised.
1 parent afd1301 commit 8645637

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

config/kube_config.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ def _refresh_azure_token(self, config):
260260
provider.value['access-token'] = token_response['accessToken']
261261
provider.value['expires-on'] = token_response['expiresOn']
262262
if self._config_persister:
263-
self._config_persister(self._config.value)
263+
self._config_persister()
264264

265265
def _load_gcp_token(self, provider):
266266
if (('config' not in provider) or
@@ -281,7 +281,7 @@ def _refresh_gcp_token(self):
281281
provider.value['access-token'] = credentials.token
282282
provider.value['expiry'] = format_rfc3339(credentials.expiry)
283283
if self._config_persister:
284-
self._config_persister(self._config.value)
284+
self._config_persister()
285285

286286
def _load_oid_token(self, provider):
287287
if 'config' not in provider:
@@ -322,7 +322,7 @@ def _load_oid_token(self, provider):
322322
self._refresh_oidc(provider)
323323

324324
if self._config_persister:
325-
self._config_persister(self._config.value)
325+
self._config_persister()
326326

327327
self.token = "Bearer %s" % provider['config']['id-token']
328328

@@ -615,7 +615,7 @@ def _get_kube_config_loader_for_yaml_file(
615615

616616
kcfg = KubeConfigMerger(filename)
617617
if persist_config and 'config_persister' not in kwargs:
618-
kwargs['config_persister'] = kcfg.save_changes()
618+
kwargs['config_persister'] = kcfg.save_changes
619619

620620
if kcfg.config is None:
621621
raise ConfigException(

0 commit comments

Comments
 (0)