Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Commit 474893b

Browse files
committed
config: Fix persist_config flag and function calls
The persist_config flag was setting the kwargs['config_persister'] to the result of the function kcfg.save_changes and not the function kcfg.save_changes itself. Once this is fixed, the second problem was that the function was called with an argument when it's defined without argument so an exception was raised.
1 parent a2d1024 commit 474893b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

config/kube_config.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ def _refresh_azure_token(self, config):
263263
provider.value['access-token'] = token_response['accessToken']
264264
provider.value['expires-on'] = token_response['expiresOn']
265265
if self._config_persister:
266-
self._config_persister(self._config.value)
266+
self._config_persister()
267267

268268
def _load_gcp_token(self, provider):
269269
if (('config' not in provider) or
@@ -284,7 +284,7 @@ def _refresh_gcp_token(self):
284284
provider.value['access-token'] = credentials.token
285285
provider.value['expiry'] = format_rfc3339(credentials.expiry)
286286
if self._config_persister:
287-
self._config_persister(self._config.value)
287+
self._config_persister()
288288

289289
def _load_oid_token(self, provider):
290290
if 'config' not in provider:
@@ -325,7 +325,7 @@ def _load_oid_token(self, provider):
325325
self._refresh_oidc(provider)
326326

327327
if self._config_persister:
328-
self._config_persister(self._config.value)
328+
self._config_persister()
329329

330330
self.token = "Bearer %s" % provider['config']['id-token']
331331

@@ -618,7 +618,7 @@ def _get_kube_config_loader_for_yaml_file(
618618

619619
kcfg = KubeConfigMerger(filename)
620620
if persist_config and 'config_persister' not in kwargs:
621-
kwargs['config_persister'] = kcfg.save_changes()
621+
kwargs['config_persister'] = kcfg.save_changes
622622

623623
if kcfg.config is None:
624624
raise ConfigException(

0 commit comments

Comments
 (0)