Skip to content

MuxedStream.ReadAsync ignores the cancellation token #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
freddyrios opened this issue May 30, 2025 · 1 comment
Open

MuxedStream.ReadAsync ignores the cancellation token #1635

freddyrios opened this issue May 30, 2025 · 1 comment

Comments

@freddyrios
Copy link

While investigating rare / hard to reproduce hangs, I noticed that MuxedStream.ReadAsync ignores the passed cancellation token. In the related StreamDemuxer class, the reads are done to the underlying web socket by passing a cancellation token that is only related to the disposal of the StreamDemuxer, so there does not seem to be a clear alternative to garantee the reads will not result in a hang in rare cases.

@tg123
Copy link
Member

tg123 commented May 30, 2025

good catch, would you like to send the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants