Leader Election doesn't properly report OnError (#1594)

tg123 · web-flow · commit a139dd594f23 · 2024-11-11T15:14:46.000Z
Fixes #1593
diff --git a/src/KubernetesClient/LeaderElection/LeaderElector.cs b/src/KubernetesClient/LeaderElection/LeaderElector.cs
@@ -163,10 +163,9 @@ private async Task<bool> TryAcquireOrRenew(CancellationToken cancellationToken)
             {
                 if (e.Response.StatusCode != HttpStatusCode.NotFound)
                 {
+                    OnError?.Invoke(e);
                     return false;
                 }
-
-                OnError?.Invoke(e);
             }
 
             if (oldLeaderElectionRecord?.AcquireTime == null ||

Original file line number	Diff line number	Diff line change
`@@ -163,10 +163,9 @@ private async Task<bool> TryAcquireOrRenew(CancellationToken cancellationToken)`
`163`	`163`	`{`
`164`	`164`	`if (e.Response.StatusCode != HttpStatusCode.NotFound)`
`165`	`165`	`{`
	`166`	`+ OnError?.Invoke(e);`
`166`	`167`	`return false;`
`167`	`168`	`}`
`168`		`-`
`169`		`- OnError?.Invoke(e);`
`170`	`169`	`}`
`171`	`170`
`172`	`171`	`if (oldLeaderElectionRecord?.AcquireTime == null \|\|`