TCK: review follow ups and additional tests / blackbox tests

* Make spec rules linkable (#2.13) and use links in TCK
* Verified 1-element-publishers are testable with TCK (skips unsupported tests)
+ moved 3.2 from subscriber tests to publisher tests
+ moved 3.4 to publisher
+ moved 3.6 spec to Publisher
+ check rule 3.3, assuming publisher breaks the reccursion
+ Splitting subscriber whitebox / blackbox tests
+ both got verifications of rule 2.3
+ whitebox is the previous impl
+ blackbox is tests which work without any additional probes
  it mostly wrapps the subscriber in order to check things
+ better 2.10 verification in blackbox
+ test was testing onComplete instead of onError like it should
+ better blackbox tests for 2.9
+ more java-doc style java-docs (added {@link}s)
+ minor cleanups and refactors to make BlackboxProxy more understandable
+ added missing delegation of boundedDepthOfOnNextAndRequestRecursion
+ improved error message when expecting error message

Author: ktoso

Diff for: README.md

@@ -35,7 +35,7 @@ public static synchronized void addHandler(Handler handler) {
 
     public static synchronized void removeHandler(Handler handler) {
         // too lazy to do the array handling
-        HashSet<Handler> set = new HashSet<>(Arrays.asList(INSTANCE.handlers));
+        HashSet<Handler> set = new HashSet<Handler>(Arrays.asList(INSTANCE.handlers));
         set.remove(handler);
         INSTANCE.handlers = set.toArray(new Handler[set.size()]);
     }

Diff for: api/src/examples/java/org/reactivestreams/example/multicast/NeverEndingStockStream.java

@@ -13,7 +13,7 @@ public class StockPriceSubscriber implements Subscriber<Stock> {
     private final int take;
 
     public StockPriceSubscriber(int bufferSize, int delayPerStock, int take) {
-        this.buffer = new ArrayBlockingQueue<>(bufferSize);
+        this.buffer = new ArrayBlockingQueue<Stock>(bufferSize);
         this.delayPerStock = delayPerStock;
         this.take = take;
     }

Diff for: api/src/examples/java/org/reactivestreams/example/multicast/StockPriceSubscriber.java

@@ -1,6 +1,7 @@
 package org.reactivestreams.example.unicast;
 
 import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicLong;
 
 import org.reactivestreams.Subscription;
 import org.reactivestreams.Subscriber;
@@ -15,7 +16,7 @@ public void subscribe(final Subscriber<Integer> s) {
 
         Subscription subscription = new Subscription() {
 
-            AtomicInteger capacity = new AtomicInteger();
+            final AtomicLong capacity = new AtomicLong();
 
             @Override
             public void request(long n) {

Diff for: api/src/examples/java/org/reactivestreams/example/unicast/InfiniteIncrementNumberPublisher.java

@@ -8,7 +8,7 @@
 class NumberSubscriberThatHopsThreads implements Subscriber<Integer> {
 
     final int BUFFER_SIZE = 10;
-    private final ArrayBlockingQueue<Integer> buffer = new ArrayBlockingQueue<>(BUFFER_SIZE);
+    private final ArrayBlockingQueue<Integer> buffer = new ArrayBlockingQueue<Integer>(BUFFER_SIZE);
     private volatile boolean terminated = false;
     private final String token;
 

Diff for: api/src/examples/java/org/reactivestreams/example/unicast/NumberSubscriberThatHopsThreads.java

@@ -17,6 +17,15 @@ private Annotations() {}
   static @interface NotVerified {
   }
 
+  /**
+   * Used to mark stochastic tests which MAY yield false positives (pass) can violate the tested rule in some specific scenario.
+   */
+  @Target(ElementType.METHOD)
+  @Retention(RetentionPolicy.SOURCE)
+  static @interface Stochastic {
+
+  }
+
   /**
    * Used to mark tests that MUST pass in all (even very restricted types of) Publishers / Subscribers.
    */
@@ -31,7 +40,7 @@ private Annotations() {}
    */
   @Target(ElementType.METHOD)
   @Retention(RetentionPolicy.SOURCE)
-  @interface Additional {
+  static @interface Additional {
     /** Description of situation when it's OK to not pass this test */
     String value() default "";