fix(service): fix missing promise rejection handlers

Credits for a GREAT debugging help via angular-ui/ui-router#2889 (comment)

Author: knalli

karma.conf.js

@@ -146,6 +146,7 @@ module.exports = function (config) {
     files : [
       injectByScope(scope, 'angular/angular.js'),
       injectByScope(scope, 'angular-mocks/angular-mocks.js'),
+      'test/unit/util/unhandledRejectionTracing.js',
       'node_modules/babel-polyfill/browser.js',
       'test/unit/test_index.js',
     ],

test/unit/binding/vertxEventBus.defaultHeaders.spec.js

@@ -1,14 +1,16 @@
 /* jshint camelcase: false, undef: true, unused: true, browser: true */
 /* global module: false, describe: false, it: false, expect: false, beforeEach: false, inject: false, SockJS: false */
 
-var SockJS = require('sockjs-client');
+const SockJS = require('sockjs-client');
+const enableUnhandledRejectionTracing = require('../util/unhandledRejectionTracing.js');
 require('../../../src/module.js');
 
 describe('integration of module::vertxEventBus (defaultHeaders)', function () {
 
   beforeEach(angular.mock.module('knalli.angular-vertxbus'));
 
   beforeEach(angular.mock.module('knalli.angular-vertxbus', function ($provide) {
+    enableUnhandledRejectionTracing(angular, $provide);
     $provide.value('$log', {
       log : function () {
       },
@@ -27,7 +29,7 @@ describe('integration of module::vertxEventBus (defaultHeaders)', function () {
 
     var vertxEventBus, $timeout, $rootScope, $log;
 
-    beforeEach(angular.mock.module('knalli.angular-vertxbus', function (vertxEventBusProvider) {
+    beforeEach(angular.mock.module('knalli.angular-vertxbus', function ($provide, vertxEventBusProvider) {
       // Override (improve test running time)
       vertxEventBusProvider.useDebug(true).useSockJsReconnectInterval(2000);
     }));
@@ -177,7 +179,8 @@ describe('integration of module::vertxEventBus (defaultHeaders)', function () {
 
     var vertxEventBus, $timeout, $rootScope, $log;
 
-    beforeEach(angular.mock.module('knalli.angular-vertxbus', function (vertxEventBusProvider) {
+    beforeEach(angular.mock.module('knalli.angular-vertxbus', function ($provide, vertxEventBusProvider) {
+      enableUnhandledRejectionTracing(angular, $provide);
       // Override (improve test running time)
       vertxEventBusProvider.useDebug(true).useSockJsReconnectInterval(2000);
     }));

test/unit/binding/vertxEventBus.spec.js

@@ -1,14 +1,16 @@
 /* jshint camelcase: false, undef: true, unused: true, browser: true */
 /* global module: false, describe: false, it: false, expect: false, beforeEach: false, inject: false, SockJS: false */
 
-var SockJS = require('sockjs-client');
+const SockJS = require('sockjs-client');
+const enableUnhandledRejectionTracing = require('../util/unhandledRejectionTracing.js');
 require('../../../src/module.js');
 
 describe('integration of module::vertxEventBus', function () {
 
   beforeEach(angular.mock.module('knalli.angular-vertxbus'));
 
   beforeEach(angular.mock.module('knalli.angular-vertxbus', function ($provide) {
+    enableUnhandledRejectionTracing(angular, $provide);
     $provide.value('$log', {
       log: function () {},
       debug: function () {},

test/unit/binding/vertxEventBusService.spec.js

@@ -1,14 +1,16 @@
 /* jshint camelcase: false, undef: true, unused: true, browser: true */
 /* global module: false, describe: false, it: false, expect: false, beforeEach: false, inject: false, SockJS: false */
 
-var SockJS = require('sockjs-client');
+const SockJS = require('sockjs-client');
+const enableUnhandledRejectionTracing = require('../util/unhandledRejectionTracing.js');
 require('../../../src/module.js');
 
 describe('integration of module::vertxEventBusService', function () {
 
   beforeEach(angular.mock.module('knalli.angular-vertxbus'));
 
   beforeEach(angular.mock.module('knalli.angular-vertxbus', function ($provide) {
+    enableUnhandledRejectionTracing(angular, $provide);
     $provide.value('$log', {
       log: function () {},
       debug: function () {},
@@ -229,10 +231,10 @@ describe('integration of module::vertxEventBusService', function () {
       describe('should replay queued items', function () {
         it('when eventbus is reopened', function (done) {
           setTimeout(function () {
-            vertxEventBusService.send('xyz', {data : 0});
-            vertxEventBusService.send('xyz', {data : 1});
-            vertxEventBusService.send('xyz', {data : 2});
-            vertxEventBusService.send('xyz', {data : 3});
+            vertxEventBusService.send('xyz', {data : 0}).then(null, angular.noop);
+            vertxEventBusService.send('xyz', {data : 1}).then(null, angular.noop);
+            vertxEventBusService.send('xyz', {data : 2}).then(null, angular.noop);
+            vertxEventBusService.send('xyz', {data : 3}).then(null, angular.noop);
 
             // fake connect
             vertxEventBus.readyState = function () {
@@ -562,13 +564,13 @@ describe('integration of module::vertxEventBusService', function () {
         expect(typeof promise.finally).to.be('function');
         promise.then(function () {
           results.then++;
-        });
+        }, angular.noop); // ignore error (because error is expected)
         promise.catch(function () {
           results.catch++;
         });
         promise.finally(function () {
           results.finally++;
-        });
+        }).then(null, angular.noop); // ignore error (because error is expected)
         $rootScope.$apply();
         setTimeout(function () {
           expect(results.then).to.be(0);
@@ -618,16 +620,16 @@ describe('integration of module::vertxEventBusService', function () {
         expect(typeof promise.finally).to.be('function');
         promise.then(function () {
           results.then++;
-        });
+        }, angular.noop); // ignore error (because error is expected)
         promise.catch(function () {
           results.catch++;
         });
         promise.finally(function () {
           results.finally++;
-        });
+        }).then(null, angular.noop); // ignore error (because error is expected)
         $rootScope.$apply();
         setTimeout(function () {
-          window.console.log(results);
+          window.console.warn(results);
           expect(results.then).to.be(0);
           expect(results.catch).to.be(1);
           expect(results.finally).to.be(1);

test/unit/util/unhandledRejectionTracing.js

@@ -0,0 +1,35 @@
+// https://github.com/angular-ui/ui-router/issues/2889#issuecomment-273944742
+module.exports = function (angular, module) {
+
+  if (angular.version.minor < 3) {
+    // will work w/ AngularJS 1.3+
+    return;
+  }
+
+  /* jshint ignore:start */
+  // Decorate the $q service when app starts
+  module.decorator('$q', ['$delegate', function ($delegate) {
+    // Create a new promise object
+    var promise = $delegate.when();
+
+    // Access the `Promise` prototype (nonstandard, but works in Chrome)
+    var proto = promise.__proto__;
+
+    // Define a setter for `$$state` that creates a stacktrace
+    // (string) and assigns it as a property of the internal `$$state` object.
+    Object.defineProperty(proto, '$$state', {
+      configurable : true,
+      enumerable : true,
+      set : function (val) {
+        val.stack = new Error().stack;
+        this._$$state = val;
+      },
+      get : function () {
+        return this._$$state;
+      }
+    });
+
+    return $delegate;
+  }]);
+  /* jshint ignore:end */
+};