Polishing.

Renamed to unwrapDate to align with the changes from spring-projects#2861.
Minor JavaDoc adjustments

See spring-projects#2857
Original pull request spring-projects#2859

Author: schauder

spring-data-jpa/src/main/java/org/springframework/data/jpa/provider/HibernateJpaParametersParameterAccessor.java

@@ -27,6 +27,7 @@
 import org.springframework.data.repository.query.Parameters;
 import org.springframework.data.repository.query.ParametersParameterAccessor;
 import org.springframework.lang.Nullable;
+import org.springframework.util.Assert;
 
 /**
  * {@link org.springframework.data.repository.query.ParameterAccessor} based on an {@link Parameters} instance. In
@@ -86,14 +87,18 @@ public Object getValue(Parameter parameter) {
 	 * For Hibernate, check if the incoming value is wrapped inside a {@link TypedParameterValue} before extracting and
 	 * casting the {@link Date}.
 	 *
-	 * @param extractedValue
-	 * @since 3.1
+	 * @param value a value that is either a {@link Date} or a  {@link TypedParameterValue} containing a {@literal Date}.
+	 * @since 3.0.4
 	 */
 	@Override
-	public Date extractDate(Object extractedValue) {
+	public Date unwrapDate(Object value) {
 
-		return (extractedValue instanceof TypedParameterValue<?> typedParameterValue)
-				? (Date) typedParameterValue.getValue()
-				: (Date) extractedValue;
+		Object extracted = (value instanceof TypedParameterValue<?> typedParameterValue) //
+				? typedParameterValue.getValue() //
+				: value;
+
+		Assert.isInstanceOf(Date.class, extracted, "Value must be either of type Date or a Date wrapped in a TypedParameterValue");
+
+		return (Date) extracted;
 	}
 }

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/JpaParametersParameterAccessor.java

@@ -59,7 +59,7 @@ public Object[] getValues() {
 	 * @param extractedValue
 	 * @since 3.1
 	 */
-	public Date extractDate(Object extractedValue) {
+	public Date unwrapDate(Object extractedValue) {
 		return (Date) extractedValue;
 	}
 

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/QueryParameterSetter.java

@@ -83,7 +83,7 @@ public void setParameter(BindableQuery query, JpaParametersParameterAccessor acc
 
 				Object extractedValue = valueExtractor.apply(accessor);
 
-				final Date value = accessor.extractDate(extractedValue);
+				final Date value = accessor.unwrapDate(extractedValue);
 
 				// One would think we can simply use parameter to identify the parameter we want to set.
 				// But that does not work with list valued parameters. At least Hibernate tries to bind them by name.

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/NamedOrIndexedQueryParameterSetterUnitTests.java

@@ -68,7 +68,7 @@ void before() {
 		Date testDate = new Date();
 
 		when(accessor.getValues()).thenReturn(new Object[] { testDate });
-		when(accessor.extractDate(testDate)).thenReturn(testDate);
+		when(accessor.unwrapDate(testDate)).thenReturn(testDate);
 
 		this.methodArguments = accessor;
 	}