Merge pull request #246 from meteorgan/type-assert

fix(type assert): add more check for type assert

Author: dtcaciuc

errcheck/errcheck.go

@@ -586,26 +586,38 @@ func (v *visitor) Visit(node ast.Node) ast.Visitor {
 			for _, name := range vspec.Names {
 				lhs = append(lhs, ast.Expr(name))
 			}
-			v.checkAssignment(lhs, vspec.Values)
+			followed := v.checkAssignment(lhs, vspec.Values)
+			if !followed {
+				return nil
+			}
 		}
 
 	case *ast.AssignStmt:
-		v.checkAssignment(stmt.Lhs, stmt.Rhs)
+		followed := v.checkAssignment(stmt.Lhs, stmt.Rhs)
+		if !followed {
+			return nil
+		}
+
+	case *ast.TypeAssertExpr:
+		v.checkAssertExpr(stmt)
+		return nil
 
 	default:
 	}
 	return v
 }
 
-func (v *visitor) checkAssignment(lhs, rhs []ast.Expr) {
+// checkAssignment checks the assignment statement and returns a boolean value
+// indicating whether to continue checking the substructure in AssignStmt or not
+func (v *visitor) checkAssignment(lhs, rhs []ast.Expr) (followed bool) {
 	if len(rhs) == 1 {
 		// single value on rhs; check against lhs identifiers
 		if call, ok := rhs[0].(*ast.CallExpr); ok {
 			if !v.blank {
-				return
+				return true
 			}
 			if v.ignoreCall(call) {
-				return
+				return true
 			}
 			isError := v.errorsByArg(call)
 			for i := 0; i < len(lhs); i++ {
@@ -619,11 +631,11 @@ func (v *visitor) checkAssignment(lhs, rhs []ast.Expr) {
 			}
 		} else if assert, ok := rhs[0].(*ast.TypeAssertExpr); ok {
 			if !v.asserts {
-				return
+				return false
 			}
 			if assert.Type == nil {
 				// type switch
-				return
+				return false
 			}
 			if len(lhs) < 2 {
 				// assertion result not read
@@ -632,6 +644,7 @@ func (v *visitor) checkAssignment(lhs, rhs []ast.Expr) {
 				// assertion result ignored
 				v.addErrorAtPosition(id.NamePos, nil)
 			}
+			return false
 		}
 	} else {
 		// multiple value on rhs; in this case a call can't return
@@ -661,6 +674,19 @@ func (v *visitor) checkAssignment(lhs, rhs []ast.Expr) {
 			}
 		}
 	}
+
+	return true
+}
+
+func (v *visitor) checkAssertExpr(expr *ast.TypeAssertExpr) {
+	if !v.asserts {
+		return
+	}
+	if expr.Type == nil {
+		// type switch
+		return
+	}
+	v.addErrorAtPosition(expr.Pos(), nil)
 }
 
 func isErrorType(t types.Type) bool {

errcheck/testdata/src/assert/main.go

@@ -3,4 +3,21 @@ package assert
 func main() {
 	var i interface{}
 	_ = i.(string) // want "unchecked error"
+
+	handleInterface(i.(string)) // want "unchecked error"
+
+	if i.(string) == "hello" { // want "unchecked error"
+		//
+	}
+
+	switch i.(type) {
+	case string:
+	case int:
+		_ = i.(int) // want "unchecked error"
+	case nil:
+	}
+}
+
+func handleInterface(i interface{}) string {
+	return i.(string) // want "unchecked error"
 }