fix(assert-checker): remove unused return value

meteorgan · meteorgan · commit c0b7cdebc9cc · 2024-06-07T17:24:55.000+08:00
diff --git a/errcheck/errcheck.go b/errcheck/errcheck.go
@@ -677,17 +677,15 @@ func (v *visitor) checkAssignment(lhs, rhs []ast.Expr) (followed bool) {
 	return
 }
 
-func (v *visitor) checkAssertExpr(expr *ast.TypeAssertExpr) bool {
+func (v *visitor) checkAssertExpr(expr *ast.TypeAssertExpr) {
 	if !v.asserts {
-		return false
+		return
 	}
 	if expr.Type == nil {
 		// type switch
-		return false
+		return
 	}
 	v.addErrorAtPosition(expr.Pos(), nil)
-
-	return false
 }
 
 func isErrorType(t types.Type) bool {

Original file line number	Diff line number	Diff line change
`@@ -677,17 +677,15 @@ func (v *visitor) checkAssignment(lhs, rhs []ast.Expr) (followed bool) {`
`677`	`677`	`return`
`678`	`678`	`}`
`679`	`679`
`680`		`-func (v visitor) checkAssertExpr(expr ast.TypeAssertExpr) bool {`
	`680`	`+func (v visitor) checkAssertExpr(expr ast.TypeAssertExpr) {`
`681`	`681`	`if !v.asserts {`
`682`		`- return false`
	`682`	`+ return`
`683`	`683`	`}`
`684`	`684`	`if expr.Type == nil {`
`685`	`685`	`// type switch`
`686`		`- return false`
	`686`	`+ return`
`687`	`687`	`}`
`688`	`688`	`v.addErrorAtPosition(expr.Pos(), nil)`
`689`		`-`
`690`		`- return false`
`691`	`689`	`}`
`692`	`690`
`693`	`691`	`func isErrorType(t types.Type) bool {`