Skip to content

Commit 35d2ca6

Browse files
committed
Remove a TODO
1 parent 9b8014a commit 35d2ca6

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

errcheck/analyzer.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,6 @@ func runAnalyzer(pass *analysis.Pass) (interface{}, error) {
6464

6565
ast.Walk(v, f)
6666

67-
// TODO have visitor report all facts and then sort out
68-
// the ones we need to report based on flags. This can
69-
// likely simplify the visitor code.
70-
7167
for _, err := range v.errors {
7268
pass.Report(analysis.Diagnostic{
7369
Pos: token.Pos(int(f.Pos()) + err.Pos.Offset),

errcheck/errcheck.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ func (v *visitor) isRecover(call *ast.CallExpr) bool {
512512
return false
513513
}
514514

515-
// TODO collect token.Pos and then convert them to UncheckedErrors
515+
// TODO (dtcaciuc) collect token.Pos and then convert them to UncheckedErrors
516516
// after visitor is done running. This will allow to integrate more cleanly
517517
// with analyzer so that we don't have to convert Position back to Pos.
518518
func (v *visitor) addErrorAtPosition(position token.Pos, call *ast.CallExpr) {

0 commit comments

Comments
 (0)