Skip to content

Commit 8787bd4

Browse files
kinowBruno P. Kinoshita
authored and
Bruno P. Kinoshita
committed
Fix pandas-dev#25099 set na_rep values before converting to string to prevent data truncation
1 parent f38020f commit 8787bd4

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

pandas/core/internals/blocks.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -749,7 +749,10 @@ def to_native_types(self, slicer=None, na_rep="nan", quoting=None, **kwargs):
749749
mask = isna(values)
750750

751751
if not self.is_object and not quoting:
752-
values = values.astype(str)
752+
if na_rep and isinstance(na_rep, str):
753+
values = values.astype("<U{length}".format(length=len(na_rep)))
754+
else:
755+
values = values.astype(str)
753756
else:
754757
values = np.array(values, dtype="object")
755758

pandas/tests/io/formats/test_to_csv.py

+16
Original file line numberDiff line numberDiff line change
@@ -515,3 +515,19 @@ def test_to_csv_compression(self, compression_only, read_infer, to_infer):
515515
df.to_csv(path, compression=to_compression)
516516
result = pd.read_csv(path, index_col=0, compression=read_compression)
517517
tm.assert_frame_equal(result, df)
518+
519+
def test_to_csv_na_rep_long_string(self, capsys):
520+
# see gh-25099
521+
df = pd.DataFrame({"c": [float('nan')] * 3})
522+
df = df.astype("Int64")
523+
expected_rows = ['c',
524+
'mynull',
525+
'mynull',
526+
'mynull']
527+
expected_ascii = tm.convert_rows_list_to_csv_str(expected_rows)
528+
529+
df.to_csv(sys.stdout, index=False, na_rep='mynull', encoding='ascii')
530+
captured = capsys.readouterr()
531+
532+
assert captured.out == expected_ascii
533+
assert not sys.stdout.closed

0 commit comments

Comments
 (0)