style(gen): add jshint and fix code styling issue

Author: DaftMonk

Diff for: Gruntfile.js

@@ -25,6 +25,13 @@ module.exports = function (grunt) {
       options: {
         files: ['CHANGELOG.md']
       }
+    },
+    jshint: {
+      options: {
+        curly: false,
+        node: true
+      },
+      all: ['Gruntfile.js', '*/index.js']
     }
   });
 

Diff for: app/index.js

@@ -104,8 +104,8 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({
         this.filters[answers.markup] = true;
         this.filters[answers.stylesheet] = true;
         this.filters[answers.router] = true;
-        this.filters['bootstrap'] = answers.bootstrap;
-        this.filters['uibootstrap'] =  answers.uibootstrap;
+        this.filters.bootstrap = answers.bootstrap;
+        this.filters.uibootstrap =  answers.uibootstrap;
       cb();
       }.bind(this));
   },
@@ -162,9 +162,9 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({
       },
       default: true
     }], function (answers) {
-      if(answers.socketio) this.filters['socketio'] = true;
-      if(answers.mongoose) this.filters['mongoose'] = true;
-      if(answers.auth) this.filters['auth'] = true;
+      if(answers.socketio) this.filters.socketio = true;
+      if(answers.mongoose) this.filters.mongoose = true;
+      if(answers.auth) this.filters.auth = true;
       if(answers.oauth) {
         answers.oauth.forEach(function(oauthStrategy) {
           this.filters[oauthStrategy] = true;
@@ -198,16 +198,16 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({
     var extensions = [];
     var filters = [];
 
-    if(this.filters['ngroute']) filters.push('ngroute');
-    if(this.filters['uirouter']) filters.push('uirouter');
-    if(this.filters['coffee']) extensions.push('coffee');
-    if(this.filters['js']) extensions.push('js');
-    if(this.filters['html']) extensions.push('html');
-    if(this.filters['jade']) extensions.push('jade');
-    if(this.filters['css']) extensions.push('css');
-    if(this.filters['stylus']) extensions.push('styl');
-    if(this.filters['sass']) extensions.push('scss');
-    if(this.filters['less']) extensions.push('less');
+    if(this.filters.ngroute) filters.push('ngroute');
+    if(this.filters.uirouter) filters.push('uirouter');
+    if(this.filters.coffee) extensions.push('coffee');
+    if(this.filters.js) extensions.push('js');
+    if(this.filters.html) extensions.push('html');
+    if(this.filters.jade) extensions.push('jade');
+    if(this.filters.css) extensions.push('css');
+    if(this.filters.stylus) extensions.push('styl');
+    if(this.filters.sass) extensions.push('scss');
+    if(this.filters.less) extensions.push('less');
 
     this.composeWith('ng-component', {
       options: {
@@ -233,10 +233,10 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({
       "'ngResource'",
       "'ngSanitize'"
     ];
-    if(this.filters['ngroute']) angModules.push("'ngRoute'");
-    if(this.filters['socketio']) angModules.push("'btford.socket-io'");
-    if(this.filters['uirouter']) angModules.push("'ui.router'");
-    if(this.filters['uibootstrap']) angModules.push("'ui.bootstrap'");
+    if(this.filters.ngroute) angModules.push("'ngRoute'");
+    if(this.filters.socketio) angModules.push("'btford.socket-io'");
+    if(this.filters.uirouter) angModules.push("'ui.router'");
+    if(this.filters.uibootstrap) angModules.push("'ui.bootstrap'");
 
     this.angularModules = "\n  " + angModules.join(",\n  ") +"\n";
   },

Diff for: endpoint/index.js

@@ -45,26 +45,26 @@ Generator.prototype.askFor = function askFor() {
 
 Generator.prototype.registerEndpoint = function registerEndpoint() {
   if(this.config.get('insertRoutes')) {
-    var config = {
+    var routeConfig = {
       file: this.config.get('registerRoutesFile'),
       needle: this.config.get('routesNeedle'),
       splicable: [
         "app.use(\'" + this.route +"\', require(\'./api/" + this.name + "\'));"
       ]
     };
-    ngUtil.rewriteFile(config);
+    ngUtil.rewriteFile(routeConfig);
   }
 
   if (this.filters.socketio) {
     if(this.config.get('insertSockets')) {
-      var config = {
+      var socketConfig = {
         file: this.config.get('registerSocketsFile'),
         needle: this.config.get('socketsNeedle'),
         splicable: [
           "require(\'../api/" + this.name + '/' + this.name + ".socket\').register(socket);"
         ]
       };
-      ngUtil.rewriteFile(config);
+      ngUtil.rewriteFile(socketConfig);
     }
   }
 };

Diff for: openshift/index.js

@@ -105,7 +105,7 @@ Generator.prototype.rhcAppShow = function rhcAppShow() {
       this.abort = true;
     }
     // No remote found
-    else if (!stdout.search('not found.') >= 0) {
+    else if (stdout.search('not found.') < 0) {
       console.log('No existing app found.');
     }
     // Error

Diff for: package.json

@@ -38,7 +38,7 @@
     "chai": "^1.9.1",
     "fs-extra": "^0.9.1",
     "grunt": "~0.4.1",
-    "grunt-contrib-jshint": "~0.7.2",
+    "grunt-contrib-jshint": "^0.10.0",
     "grunt-conventional-changelog": "~1.0.0",
     "grunt-release": "~0.6.0",
     "load-grunt-tasks": "~0.2.0",