Skip to content

Commit db131a9

Browse files
filipesilvakieronqtran
authored andcommitted
chore(build): remove tslint options
We've removed tslint from build cycles a while ago, but these options remained. Close angular#2616
1 parent 91e6171 commit db131a9

File tree

2 files changed

+10
-28
lines changed

2 files changed

+10
-28
lines changed

packages/angular-cli/models/webpack-build-development.ts

-23
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,5 @@
11
const path = require('path');
22

3-
import * as webpack from 'webpack';
4-
5-
declare module 'webpack' {
6-
export interface LoaderOptionsPlugin {}
7-
export interface LoaderOptionsPluginStatic {
8-
new (optionsObject: any): LoaderOptionsPlugin;
9-
}
10-
interface Webpack {
11-
LoaderOptionsPlugin: LoaderOptionsPluginStatic;
12-
}
13-
};
14-
153
export const getWebpackDevConfigPartial = function(projectRoot: string, appConfig: any) {
164
return {
175
devtool: 'cheap-module-source-map',
@@ -21,17 +9,6 @@ export const getWebpackDevConfigPartial = function(projectRoot: string, appConfi
219
sourceMapFilename: '[name].map',
2210
chunkFilename: '[id].chunk.js'
2311
},
24-
plugins: [
25-
new webpack.LoaderOptionsPlugin({
26-
options: {
27-
tslint: {
28-
emitErrors: false,
29-
failOnHint: false,
30-
resourcePath: path.resolve(projectRoot, appConfig.root)
31-
},
32-
}
33-
})
34-
],
3512
node: {
3613
fs: 'empty',
3714
global: true,

packages/angular-cli/models/webpack-build-production.ts

+10-5
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,16 @@ const WebpackMd5Hash = require('webpack-md5-hash');
33
const CompressionPlugin = require('compression-webpack-plugin');
44
import * as webpack from 'webpack';
55

6+
declare module 'webpack' {
7+
export interface LoaderOptionsPlugin {}
8+
export interface LoaderOptionsPluginStatic {
9+
new (optionsObject: any): LoaderOptionsPlugin;
10+
}
11+
interface Webpack {
12+
LoaderOptionsPlugin: LoaderOptionsPluginStatic;
13+
}
14+
}
15+
616
export const getWebpackProdConfigPartial = function(projectRoot: string, appConfig: any) {
717
return {
818
devtool: 'source-map',
@@ -28,11 +38,6 @@ export const getWebpackProdConfigPartial = function(projectRoot: string, appConf
2838
}),
2939
new webpack.LoaderOptionsPlugin({
3040
options: {
31-
tslint: {
32-
emitErrors: true,
33-
failOnHint: true,
34-
resourcePath: path.resolve(projectRoot, appConfig.root)
35-
},
3641
htmlLoader: {
3742
minimize: true,
3843
removeAttributeQuotes: false,

0 commit comments

Comments
 (0)