Skip to content

Commit 3ed582e

Browse files
rramkumar1kfswain
authored andcommitted
Add support for configuring ports in BBR helm chart (kubernetes-sigs#601)
1 parent 433da6e commit 3ed582e

File tree

5 files changed

+12
-9
lines changed

5 files changed

+12
-9
lines changed

config/charts/body-based-routing/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,14 @@ The following table list the configurable parameters of the chart.
4040
|---------------------------------------------|----------------------------------------------------------------------------------------------------|
4141
| `bbr.name` | Name for the deployment and service. |
4242
| `bbr.replicas` | Number of replicas for the deployment. Defaults to `1`. |
43+
| `bbr.port` | Port serving ext_proc. Defaults to `9004`. |
44+
| `bbr.healthCheckPort` | Port for health checks. Defaults to `9005`. |
4345
| `bbr.image.name` | Name of the container image used. |
4446
| `bbr.image.hub` | Registry URL where the image is hosted. |
4547
| `bbr.image.tag` | Image tag. |
4648
| `bbr.image.pullPolicy` | Image pull policy for the container. Possible values: `Always`, `IfNotPresent`, or `Never`. Defaults to `Always`. |
4749
| `provider.name` | Name of the Inference Gateway implementation being used. Possible values: `istio`, `gke`. Defaults to `none`. |
48-
| `inference-gateway.name` | The name of the Gateway. Defaults to `inference-gateway`. |
50+
| `inference-gateway.name` | The name of the Gateway. Defaults to `inference-gateway`. |
4951

5052
## Notes
5153

config/charts/body-based-routing/templates/bbr.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ spec:
2222
- "-v"
2323
- "3"
2424
ports:
25-
- containerPort: 9004
25+
- containerPort: {{ .Values.bbr.port }}
2626
# health check
27-
- containerPort: 9005
27+
- containerPort: {{ .Values.bbr.healthCheckPort }}
2828
---
2929
apiVersion: v1
3030
kind: Service
@@ -36,7 +36,7 @@ spec:
3636
app: {{ .Values.bbr.name }}
3737
ports:
3838
- protocol: TCP
39-
port: 9004
40-
targetPort: 9004
39+
port: {{ .Values.bbr.port }}
40+
targetPort: {{ .Values.bbr.port }}
4141
appProtocol: HTTP2
4242
type: ClusterIP

config/charts/body-based-routing/templates/gke.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ spec:
2525
group: ""
2626
kind: Service
2727
name: {{ .Values.bbr.name }}
28-
port: 9004
28+
port: {{ .Values.bbr.port }}
2929
---
3030
apiVersion: networking.gke.io/v1
3131
kind: HealthCheckPolicy
@@ -40,7 +40,7 @@ spec:
4040
type: "GRPC"
4141
grpcHealthCheck:
4242
portSpecification: "USE_FIXED_PORT"
43-
port: 9005
43+
port: {{ .Values.bbr.healthCheckPort }}
4444
targetRef:
4545
group: ""
4646
kind: Service

config/charts/body-based-routing/templates/istio.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
response_trailer_mode: "SKIP"
3232
grpc_service:
3333
envoy_grpc:
34-
cluster_name: outbound|9004||{{ .Values.bbr.name }}.default.svc.cluster.local
34+
cluster_name: outbound|{{ .Values.bbr.port }}||{{ .Values.bbr.name }}.default.svc.cluster.local
3535
---
3636
apiVersion: networking.istio.io/v1
3737
kind: DestinationRule

config/charts/body-based-routing/values.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ bbr:
66
hub: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension
77
tag: main
88
pullPolicy: Always
9-
extProcPort: 9002
9+
port: 9004
10+
healthCheckPort: 9005
1011

1112
provider:
1213
name: none

0 commit comments

Comments
 (0)