TYP: add type annotation to _xlwt.py pandas-dev#36024 (pandas-dev#36025)

Author: fangchenli

pandas/io/excel/_xlwt.py

@@ -1,8 +1,13 @@
+from typing import TYPE_CHECKING, Dict
+
 import pandas._libs.json as json
 
 from pandas.io.excel._base import ExcelWriter
 from pandas.io.excel._util import _validate_freeze_panes
 
+if TYPE_CHECKING:
+    from xlwt import XFStyle
+
 
 class _XlwtWriter(ExcelWriter):
     engine = "xlwt"
@@ -29,12 +34,11 @@ def save(self):
         """
         Save workbook to disk.
         """
-        return self.book.save(self.path)
+        self.book.save(self.path)
 
     def write_cells(
         self, cells, sheet_name=None, startrow=0, startcol=0, freeze_panes=None
     ):
-        # Write the frame cells using xlwt.
 
         sheet_name = self._get_sheet_name(sheet_name)
 
@@ -49,7 +53,7 @@ def write_cells(
             wks.set_horz_split_pos(freeze_panes[0])
             wks.set_vert_split_pos(freeze_panes[1])
 
-        style_dict = {}
+        style_dict: Dict[str, XFStyle] = {}
 
         for cell in cells:
             val, fmt = self._value_with_fmt(cell.val)
@@ -101,14 +105,14 @@ def _style_to_xlwt(
                     f"{key}: {cls._style_to_xlwt(value, False)}"
                     for key, value in item.items()
                 ]
-                out = f"{(line_sep).join(it)} "
+                out = f"{line_sep.join(it)} "
                 return out
             else:
                 it = [
                     f"{key} {cls._style_to_xlwt(value, False)}"
                     for key, value in item.items()
                 ]
-                out = f"{(field_sep).join(it)} "
+                out = f"{field_sep.join(it)} "
                 return out
         else:
             item = f"{item}"

setup.cfg

@@ -223,9 +223,6 @@ check_untyped_defs=False
 [mypy-pandas.io.excel._util]
 check_untyped_defs=False
 
-[mypy-pandas.io.excel._xlwt]
-check_untyped_defs=False
-
 [mypy-pandas.io.formats.console]
 check_untyped_defs=False