CLN: remove unnecessary _convert_index_indexer (pandas-dev#36394)

Author: jbrockmendel

pandas/core/indexes/base.py

@@ -3252,7 +3252,7 @@ def _convert_listlike_indexer(self, keyarr):
             Return tuple-safe keys.
         """
         if isinstance(keyarr, Index):
-            keyarr = self._convert_index_indexer(keyarr)
+            pass
         else:
             keyarr = self._convert_arr_indexer(keyarr)
 
@@ -3275,21 +3275,6 @@ def _convert_arr_indexer(self, keyarr):
         keyarr = com.asarray_tuplesafe(keyarr)
         return keyarr
 
-    def _convert_index_indexer(self, keyarr):
-        """
-        Convert an Index indexer to the appropriate dtype.
-
-        Parameters
-        ----------
-        keyarr : Index (or sub-class)
-            Indexer to convert.
-
-        Returns
-        -------
-        converted_keyarr : Index (or sub-class)
-        """
-        return keyarr
-
     def _convert_list_indexer(self, keyarr):
         """
         Convert a list-like indexer to the appropriate dtype.

pandas/core/indexes/category.py

@@ -583,10 +583,6 @@ def _convert_arr_indexer(self, keyarr):
 
         return self._shallow_copy(keyarr)
 
-    @doc(Index._convert_index_indexer)
-    def _convert_index_indexer(self, keyarr):
-        return self._shallow_copy(keyarr)
-
     @doc(Index._maybe_cast_slice_bound)
     def _maybe_cast_slice_bound(self, label, side, kind):
         if kind == "loc":

pandas/core/indexes/numeric.py

@@ -308,15 +308,6 @@ def _convert_arr_indexer(self, keyarr):
 
         return com.asarray_tuplesafe(keyarr, dtype=dtype)
 
-    @doc(Index._convert_index_indexer)
-    def _convert_index_indexer(self, keyarr):
-        # Cast the indexer to uint64 if possible so
-        # that the values returned from indexing are
-        # also uint64.
-        if keyarr.is_integer():
-            return keyarr.astype(np.uint64)
-        return keyarr
-
     # ----------------------------------------------------------------
 
     @classmethod

pandas/tests/indexes/test_numeric.py

@@ -631,7 +631,11 @@ def test_range_float_union_dtype():
     tm.assert_index_equal(result, expected)
 
 
-def test_uint_index_does_not_convert_to_float64():
+@pytest.mark.parametrize(
+    "box",
+    [list, lambda x: np.array(x, dtype=object), lambda x: pd.Index(x, dtype=object)],
+)
+def test_uint_index_does_not_convert_to_float64(box):
     # https://github.com/pandas-dev/pandas/issues/28279
     # https://github.com/pandas-dev/pandas/issues/28023
     series = pd.Series(
@@ -646,7 +650,7 @@ def test_uint_index_does_not_convert_to_float64():
         ],
     )
 
-    result = series.loc[[7606741985629028552, 17876870360202815256]]
+    result = series.loc[box([7606741985629028552, 17876870360202815256])]
 
     expected = UInt64Index(
         [7606741985629028552, 17876870360202815256, 17876870360202815256],