Would it be possible to add a positive commission?

[AlgoQ]

I'm trying to backtest a limit orders based strategy on a crypto exchange named bybit. The problem is that you get rebates when you use limit orders. But I see I can't enter positive commissions (-0.00025). Would it be possible to change this?

AssertionError: commission should be between 0-10%, is -0.00025

[kernc]

For now, why not amend the line:

backtesting.py/backtesting/backtesting.py

Line 667 in 73e1534

assert 0 <= commission < .1, f"commission should be between 0-10%, is {commission}"

in you own copy, and try it out.

Do report if anything breaks.

[AlgoQ]

Thanks!

[kernc]

Did you solve it? Does it work?

[AlgoQ]

Yeah I changed the line to this and everything worked afterwards, with the results I was expecting.

 assert -0.1 <= commission < .1, f"commission should be between -10% -> 10%, is {commission}" 

[kernc]

If you PR it with text ... between -10% (e.g. market-maker's rebates) and 10% (fees), I'll accept it.