Skip to content

Commit fc34176

Browse files
Merge pull request DefinitelyTyped#6812 from DanielRosenwasser/errorHandlerFix
Don't use 'any' for 'errorhandler'.
2 parents 961b76f + fa49ff9 commit fc34176

File tree

2 files changed

+32
-2
lines changed

2 files changed

+32
-2
lines changed

errorhandler/errorhandler-tests.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,13 @@ import errorhandler = require('errorhandler');
55
var app = express();
66

77
app.use(errorhandler());
8+
9+
app.use(errorhandler({ log: true }));
10+
11+
app.use(errorhandler({ log: (err, str, req, res) => {
12+
const { message, name, stack } = err;
13+
const messageIsStr = message === str;
14+
15+
const requestWasFresh = req && req.fresh;
16+
const responseContentType = res && res.contentType
17+
}}))

errorhandler/errorhandler.d.ts

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,26 @@
77

88
declare module "errorhandler" {
99
import express = require('express');
10-
function e(options?: {log?: any}): express.ErrorRequestHandler;
11-
export = e;
10+
11+
function errorHandler(options?: errorHandler.Options): express.ErrorRequestHandler;
12+
13+
namespace errorHandler {
14+
interface LoggingCallback {
15+
(err: Error, str: string, req: express.Request, res: express.Response): void;
16+
}
17+
18+
interface Options {
19+
/**
20+
* Defaults to true.
21+
*
22+
* Possible values:
23+
* true : Log errors using console.error(str).
24+
* false : Only send the error back in the response.
25+
* A function : pass the error to a function for handling.
26+
*/
27+
log: boolean | LoggingCallback;
28+
}
29+
}
30+
31+
export = errorHandler;
1232
}

0 commit comments

Comments
 (0)