Skip to content

Commit d6c51c6

Browse files
committed
Merge pull request DefinitelyTyped#7800 from ccurrens/request
Add specialized overloads for request events
2 parents b3df8c8 + e252a08 commit d6c51c6

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

request/request-tests.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -640,3 +640,15 @@ request({url: 'http://www.google.com', jar: j}, function () {
640640
var cookies = j.getCookies(url);
641641
// [{key: 'key1', value: 'value1', domain: "www.google.com", ...}, ...]
642642
});
643+
644+
request(
645+
{ method: 'GET'
646+
, uri: 'http://www.google.com'
647+
, gzip: true
648+
}
649+
)
650+
.on('request', function(req: http.ClientRequest) { })
651+
.on('response', function(resp: http.IncomingMessage) { })
652+
.on('data', function(data: Buffer | string) { })
653+
.on('error', function(e: Error) { })
654+
.on('complete', function(resp: http.IncomingMessage, body?: string | Buffer) { });

request/request.d.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Type definitions for request
22
// Project: https://github.com/mikeal/request
3-
// Definitions by: Carlos Ballesteros Velasco <https://github.com/soywiz>, bonnici <https://github.com/bonnici>, Bart van der Schoor <https://github.com/Bartvds>, Joe Skeen <http://github.com/joeskeen>
3+
// Definitions by: Carlos Ballesteros Velasco <https://github.com/soywiz>, bonnici <https://github.com/bonnici>, Bart van der Schoor <https://github.com/Bartvds>, Joe Skeen <http://github.com/joeskeen>, Christopher Currens <https://github.com/ccurrens>
44
// Definitions: https://github.com/borisyankov/DefinitelyTyped
55

66
// Imported from: https://github.com/soywiz/typescript-node-definitions/d.ts
@@ -180,6 +180,11 @@ declare module 'request' {
180180
jar(jar: CookieJar): Request;
181181

182182
on(event: string, listener: Function): Request;
183+
on(event: 'request', listener: (req: http.ClientRequest) => void): Request;
184+
on(event: 'response', listener: (resp: http.IncomingMessage) => void): Request;
185+
on(event: 'data', listener: (data: Buffer | string) => void): Request;
186+
on(event: 'error', listener: (e: Error) => void): Request;
187+
on(event: 'complete', listener: (resp: http.IncomingMessage, body?: string | Buffer) => void): Request;
183188

184189
write(buffer: Buffer, cb?: Function): boolean;
185190
write(str: string, cb?: Function): boolean;

0 commit comments

Comments
 (0)