Skip to content

Commit cda0144

Browse files
committed
Fix big-integer comparison method return types
1 parent 9267116 commit cda0144

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

big-integer/big-integer-tests.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ var noArgument = bigInt(),
66
stringArgument = bigInt( "75643564363473453456342378564387956906736546456235345" ),
77
baseArgumentInt = bigInt( "101010", 2 ),
88
baseArgumentStr = bigInt( "101010", "2" ),
9-
baseArgumentBi = bigInt( "101010", bigInt( 2 ) ),
9+
baseArgumentBi = bigInt( "101010", bigInt( 2 ) ),
1010
bigIntArgument = bigInt( noArgument );
1111

1212
// method tests
@@ -26,13 +26,13 @@ isBigInteger = x.add( 0 );
2626
isBigInteger = x.add( x );
2727
isBigInteger = x.add( "100" );
2828

29-
isBigInteger = x.compare( 0 );
30-
isBigInteger = x.compare( x );
31-
isBigInteger = x.compare( "100" );
29+
isNumber = x.compare( 0 );
30+
isNumber = x.compare( x );
31+
isNumber = x.compare( "100" );
3232

33-
isBigInteger = x.compareAbs( 0 );
34-
isBigInteger = x.compareAbs( x );
35-
isBigInteger = x.compareAbs( "100" );
33+
isNumber = x.compareAbs( 0 );
34+
isNumber = x.compareAbs( x );
35+
isNumber = x.compareAbs( "100" );
3636

3737
isBigInteger = x.divide( 0 );
3838
isBigInteger = x.divide( x );

big-integer/big-integer.d.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -134,24 +134,24 @@ interface BigInteger {
134134
* Performs a comparison between two numbers. If the numbers are equal, it returns 0.
135135
* If the first number is greater, it returns 1. If the first number is lesser, it returns -1.
136136
*/
137-
compare( number: number ): BigInteger;
137+
compare( number: number ): number;
138138
/**
139139
* Performs a comparison between two numbers. If the numbers are equal, it returns 0.
140140
* If the first number is greater, it returns 1. If the first number is lesser, it returns -1.
141141
*/
142-
compare( number: BigInteger ): BigInteger;
142+
compare( number: BigInteger ): number;
143143
/**
144144
* Performs a comparison between two numbers. If the numbers are equal, it returns 0.
145145
* If the first number is greater, it returns 1. If the first number is lesser, it returns -1.
146146
*/
147-
compare( number: string ): BigInteger;
147+
compare( number: string ): number;
148148

149149
/** Performs a comparison between the absolute value of two numbers. */
150-
compareAbs( number: number ): BigInteger;
150+
compareAbs( number: number ): number;
151151
/** Performs a comparison between the absolute value of two numbers. */
152-
compareAbs( number: BigInteger ): BigInteger;
152+
compareAbs( number: BigInteger ): number;
153153
/** Performs a comparison between the absolute value of two numbers. */
154-
compareAbs( number: string ): BigInteger;
154+
compareAbs( number: string ): number;
155155

156156
/** Checks if two numbers are equal. */
157157
equals( number: number ): boolean;

0 commit comments

Comments
 (0)