Skip to content

Commit b009ee2

Browse files
committed
Merge pull request DefinitelyTyped#4743 from lazutkin/master
Fixes DefinitelyTyped#4742 ctor definition of ObjectId
2 parents 6201d8f + 7776946 commit b009ee2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mongoose/mongoose-tests.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,6 +368,7 @@ schema.virtual('display_name')
368368
.set((value: string): void => {});
369369

370370
var id: mongoose.Types.ObjectId = new mongoose.Types.ObjectId('foo');
371+
var id: mongoose.Types.ObjectId = new mongoose.Types.ObjectId();
371372
var id2: mongoose.Types.ObjectId = new mongoose.Types.ObjectId(123);
372373
var id2: mongoose.Types.ObjectId = mongoose.Types.ObjectId.createFromTime(123);
373374
var id2: mongoose.Types.ObjectId = mongoose.Types.ObjectId.createFromHexString('foo');
@@ -377,4 +378,4 @@ var eq = id.equals(id2);
377378

378379
var kitty1 = new Kitty({});
379380
var kitty2 = new Kitty({});
380-
var kittyEq = kitty1._id.equals(kitty2._id);
381+
var kittyEq = kitty1._id.equals(kitty2._id);

mongoose/mongoose.d.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ declare module "mongoose" {
7979
}
8080
export module Types {
8181
export class ObjectId {
82-
constructor(id: string|number);
82+
constructor(id?: string|number);
8383
toHexString(): string;
8484
equals(other: ObjectId): boolean;
8585
getTimestamp(): Date;
@@ -458,4 +458,3 @@ declare module "mongoose" {
458458
}
459459

460460
}
461-

0 commit comments

Comments
 (0)