Skip to content

Commit 264d1a4

Browse files
committed
Merge pull request DefinitelyTyped#4452 from frankbille/patch-1
Return Firebase as type from $ref
2 parents f23cd55 + b67ca75 commit 264d1a4

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

angularfire/angularfire-tests.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ myapp.controller("MyController", ["$scope", "$firebase", '$FirebaseObject', '$Fi
4646

4747
// AngularFireObject
4848
{
49-
var obj = sync.$asObject();
49+
var obj = $FirebaseObject(ref);
5050

5151
// $id
5252
if (obj.$id !== ref.name()) throw "error";
@@ -63,7 +63,7 @@ myapp.controller("MyController", ["$scope", "$firebase", '$FirebaseObject', '$Fi
6363
});
6464

6565
// $ref()
66-
if (obj.$ref() !== sync) throw "error";
66+
if (obj.$ref() !== ref) throw "error";
6767

6868
// $bindTo()
6969
obj.$bindTo($scope, "data").then(function () {
@@ -92,10 +92,10 @@ myapp.controller("MyController", ["$scope", "$firebase", '$FirebaseObject', '$Fi
9292

9393
// AngularFireArray
9494
{
95-
var list = sync.$asArray();
95+
var list = $FirebaseArray(ref);
9696

9797
// $ref()
98-
if (list.$ref() !== sync) throw "error";
98+
if (list.$ref() !== ref) throw "error";
9999

100100
// $add()
101101
list.$add({ foo: "foo value" });

angularfire/angularfire.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ interface AngularFireObject extends AngularFireSimpleObject {
3333
$loaded(resolve?: (x: AngularFireObject) => ng.IHttpPromise<{}>, reject?: (err: any) => any): ng.IPromise<AngularFireObject>;
3434
$loaded(resolve?: (x: AngularFireObject) => ng.IPromise<{}>, reject?: (err: any) => any): ng.IPromise<AngularFireObject>;
3535
$loaded(resolve?: (x: AngularFireObject) => void, reject?: (err: any) => any): ng.IPromise<AngularFireObject>;
36-
$ref(): AngularFire;
36+
$ref(): Firebase;
3737
$bindTo(scope: ng.IScope, varName: string): ng.IPromise<any>;
3838
$watch(callback: Function, context?: any): Function;
3939
$destroy(): void;
@@ -53,7 +53,7 @@ interface AngularFireArray extends Array<AngularFireSimpleObject> {
5353
$loaded(resolve?: (x: AngularFireArray) => ng.IHttpPromise<{}>, reject?: (err: any) => any): ng.IPromise<AngularFireArray>;
5454
$loaded(resolve?: (x: AngularFireArray) => ng.IPromise<{}>, reject?: (err: any) => any): ng.IPromise<AngularFireArray>;
5555
$loaded(resolve?: (x: AngularFireArray) => void, reject?: (err: any) => any): ng.IPromise<AngularFireArray>;
56-
$ref(): AngularFire;
56+
$ref(): Firebase;
5757
$watch(cb: (event: string, key: string, prevChild: string) => void, context?: any): Function;
5858
$destroy(): void;
5959
}

0 commit comments

Comments
 (0)