Skip to content

Commit 096ab8c

Browse files
committed
Merge pull request DefinitelyTyped#4312 from mrk21/fix-react-router.d.ts
Fix DefinitelyTyped#4267(react-router/react-router.d.ts)
2 parents 5bee563 + ebfa2af commit 096ab8c

File tree

2 files changed

+23
-3
lines changed

2 files changed

+23
-3
lines changed

react-router/react-router-test.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ class CreateTest {
263263
v: Router.Router;
264264

265265
constructor() {
266+
// React.createElement() version
266267
this.v = Router.create({
267268
routes: React.createElement(Router.Route, null)
268269
});
@@ -271,6 +272,16 @@ class CreateTest {
271272
location: Router.HistoryLocation,
272273
scrollBehavior: Router.ImitateBrowserBehavior
273274
});
275+
276+
// React.createFactory() version
277+
this.v = Router.create({
278+
routes: React.createFactory(Router.Route)()
279+
});
280+
this.v = Router.create({
281+
routes: React.createFactory(Router.Route)(),
282+
location: Router.HistoryLocation,
283+
scrollBehavior: Router.ImitateBrowserBehavior
284+
});
274285
}
275286

276287
run() {
@@ -281,12 +292,21 @@ class CreateTest {
281292

282293
class RunTest {
283294
constructor() {
295+
// React.createElement() version
284296
var v1: Router.Router = Router.run(React.createElement(Router.Route, null), (Handler) => {
285297
React.render(React.createElement(Handler, null), document.body);
286298
});
287299
var v2: Router.Router = Router.run(React.createElement(Router.Route, null), Router.HistoryLocation, (Handler, state) => {
288300
React.render(React.createElement(Handler, null), document.body);
289301
});
302+
303+
// React.createFactory() version
304+
var v3: Router.Router = Router.run(React.createFactory(Router.Route)(), (Handler) => {
305+
React.render(React.createElement(Handler, null), document.body);
306+
});
307+
var v4: Router.Router = Router.run(React.createFactory(Router.Route)(), Router.HistoryLocation, (Handler, state) => {
308+
React.render(React.createElement(Handler, null), document.body);
309+
});
290310
}
291311
}
292312

react-router/react-router.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,16 +179,16 @@ declare module ReactRouter {
179179
}
180180

181181
interface RouterCreateOption {
182-
routes: Route;
182+
routes: React.ReactElement<RouteProp>;
183183
location?: LocationBase;
184184
scrollBehavior?: ScrollBehaviorBase;
185185
}
186186

187187
type RouterRunCallback = (Handler: Router, state: RouterState) => void;
188188

189189
function create(options: RouterCreateOption): Router;
190-
function run(routes: Route, callback: RouterRunCallback): Router;
191-
function run(routes: Route, location: LocationBase, callback: RouterRunCallback): Router;
190+
function run(routes: React.ReactElement<RouteProp>, callback: RouterRunCallback): Router;
191+
function run(routes: React.ReactElement<RouteProp>, location: LocationBase, callback: RouterRunCallback): Router;
192192

193193

194194
//

0 commit comments

Comments
 (0)