Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

Commit 8f55257

Browse files
authored
Merge pull request #5006 from GabyCT/topic/writefio
metrics: Enable write io and bw for FIO metrics
2 parents f46a863 + 4f8b2dd commit 8f55257

File tree

2 files changed

+41
-4
lines changed

2 files changed

+41
-4
lines changed

cmd/checkmetrics/ci_worker/checkmetrics-json-cloud-hypervisor-sv-c1-small-x86-01.toml

Lines changed: 31 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ description = "measure network latency"
5656
checkvar = ".\"latency\".Results | .[] | .latency.Result"
5757
checktype = "mean"
5858
midval = 0.73
59-
minpercent = 10.0
59+
minpercent = 20.0
6060
maxpercent = 10.0
6161

6262
[[metric]]
@@ -96,7 +96,7 @@ checkvar = ".\"fio\".Results | .[] | .readio.Result"
9696
checktype = "mean"
9797
midval = 7811072.0
9898
minpercent = 20.0
99-
maxpercent = 10.0
99+
maxpercent = 20.0
100100

101101
[[metric]]
102102
name = "fio"
@@ -109,8 +109,35 @@ checkvar = ".\"fio\".Results | .[] | .readbw.Result"
109109
checktype = "mean"
110110
midval = 88479751.0
111111
minpercent = 25.0
112+
maxpercent = 25.0
113+
114+
[[metric]]
115+
name = "fio"
116+
type = "json"
117+
description = "measure write-io using fio"
118+
# Min and Max values to set a 'range' that
119+
# the median of the CSV Results data must fall
120+
# within (inclusive)
121+
checkvar = ".\"fio\".Results | .[] | .writeio.Result"
122+
checktype = "mean"
123+
midval = 2674688.0
124+
minpercent = 20.0
112125
maxpercent = 10.0
113126

127+
[[metric]]
128+
name = "fio"
129+
type = "json"
130+
description = "measure write-bw using fio"
131+
# Min and Max values to set a 'range' that
132+
# the median of the CSV Results data must fall
133+
# within (inclusive)
134+
checkvar = ".\"fio\".Results | .[] | .writebw.Result"
135+
checktype = "mean"
136+
midval = 35543338.0
137+
minpercent = 40.0
138+
maxpercent = 30.0
139+
140+
114141
[[metric]]
115142
name = "network-iperf3"
116143
type = "json"
@@ -135,7 +162,7 @@ checkvar = ".\"fio\".Results | .[] | .read90percentile.Result"
135162
checktype = "mean"
136163
midval = 56668.0
137164
minpercent = 50.0
138-
maxpercent = 50.0
165+
maxpercent = 60.0
139166

140167
[[metric]]
141168
name = "fio"
@@ -148,7 +175,7 @@ checkvar = ".\"fio\".Results | .[] | .read95percentile.Result"
148175
checktype = "mean"
149176
midval = 84454.0
150177
minpercent = 50.0
151-
maxpercent = 50.0
178+
maxpercent = 60.0
152179

153180
[[metric]]
154181
name = "network-iperf3"

metrics/storage/fio-k8s/fio-test-ci.sh

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ function main() {
3838
local read_bw=$(cat $test_result_file | grep bw_bytes | head -1 | sed 's/[[:blank:]]//g' | cut -f2 -d ':' | cut -f1 -d ',')
3939
local read_90_percentile=$(cat $test_result_file | grep 90.000000 | head -1 | sed 's/[[:blank:]]//g' | cut -f2 -d ':' | cut -f1 -d ',')
4040
local read_95_percentile=$(cat $test_result_file | grep 95.000000 | head -1 | sed 's/[[:blank:]]//g' | cut -f2 -d ':' | cut -f1 -d ',')
41+
local write_io=$(cat $test_result_file | grep io_bytes | head -2 | tail -1 | sed 's/[[:blank:]]//g' | cut -f2 -d ':' | cut -f1 -d ',')
42+
local write_bw=$(cat $test_result_file | grep bw_bytes | head -2 | tail -1 | sed 's/[[:blank:]]//g' | cut -f2 -d ':' | cut -f1 -d ',')
4143

4244
metrics_json_start_array
4345
local json="$(cat << EOF
@@ -57,6 +59,14 @@ function main() {
5759
"read95percentile": {
5860
"Result" : $read_95_percentile,
5961
"Units" : "ns"
62+
},
63+
"writeio": {
64+
"Result" : $write_io,
65+
"Units" : "bytes"
66+
},
67+
"writebw": {
68+
"Result" : $write_bw,
69+
"Units" : "bytes/sec"
6070
}
6171
}
6272
EOF

0 commit comments

Comments
 (0)