Skip to content

Commit 89a7a1c

Browse files
blackswannydignifiedquire
authored andcommitted
fix: filter browser logging by level of LOG
Additional fix to the bug, "filter browser logging by level" ([35965d9](35965d9)), closes [#2228](#2228) Otherwise console.log ignore doesn't work with ``` browserConsoleLogOptions: { level: 'debug', terminal: true } ```
1 parent eaeffe9 commit 89a7a1c

File tree

3 files changed

+44
-4
lines changed

3 files changed

+44
-4
lines changed

lib/constants.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@ exports.LOG_ERROR = 'ERROR'
1515
exports.LOG_WARN = 'WARN'
1616
exports.LOG_INFO = 'INFO'
1717
exports.LOG_DEBUG = 'DEBUG'
18+
exports.LOG_LOG = 'LOG'
1819
exports.LOG_PRIORITIES = [
1920
exports.LOG_DISABLE,
2021
exports.LOG_ERROR,
2122
exports.LOG_WARN,
2223
exports.LOG_INFO,
2324
exports.LOG_DEBUG,
24-
exports.LOG_DISABLE
25+
exports.LOG_LOG
2526
]
2627

2728
// Default patterns for the pattern layout.

test/e2e/browser_console.feature

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ Feature: Browser Console Configuration
1111
plugins = [
1212
'karma-jasmine',
1313
'karma-phantomjs-launcher'
14-
];
14+
],
15+
browserConsoleLogOptions = {
16+
level: 'log'
17+
};
1518
"""
1619
When I start Karma
1720
Then it passes with like:

test/unit/reporters/base.spec.js

Lines changed: 38 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,45 @@ describe('reporter', function () {
8383
return expect(writeSpy).to.have.been.calledWith('LOG: Message\n')
8484
})
8585

86-
it('should not log if lower priority than browserConsoleLogOptions.level', function () {
86+
it('should not log if lower priority than browserConsoleLogOptions "error"', function () {
8787
var reporter = new m.BaseReporter(null, null, true, {
88-
browserConsoleLogOptions: {level: 'ERROR'}
88+
browserConsoleLogOptions: {level: 'error'}
89+
}, adapter)
90+
var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
91+
92+
reporter._browsers = ['Chrome']
93+
reporter.onBrowserLog('Chrome', 'Message', 'WARN')
94+
95+
return writeSpy.should.have.not.been.called
96+
})
97+
98+
it('should not log if lower priority than browserConsoleLogOptions "warn"', function () {
99+
var reporter = new m.BaseReporter(null, null, true, {
100+
browserConsoleLogOptions: {level: 'warn'}
101+
}, adapter)
102+
var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
103+
104+
reporter._browsers = ['Chrome']
105+
reporter.onBrowserLog('Chrome', 'Message', 'INFO')
106+
107+
return writeSpy.should.have.not.been.called
108+
})
109+
110+
it('should not log if lower priority than browserConsoleLogOptions "info"', function () {
111+
var reporter = new m.BaseReporter(null, null, true, {
112+
browserConsoleLogOptions: {level: 'info'}
113+
}, adapter)
114+
var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
115+
116+
reporter._browsers = ['Chrome']
117+
reporter.onBrowserLog('Chrome', 'Message', 'DEBUG')
118+
119+
return writeSpy.should.have.not.been.called
120+
})
121+
122+
it('should not log if lower priority than browserConsoleLogOptions "debug"', function () {
123+
var reporter = new m.BaseReporter(null, null, true, {
124+
browserConsoleLogOptions: {level: 'debug'}
89125
}, adapter)
90126
var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
91127

0 commit comments

Comments
 (0)