Skip to content

Commit 5d09cbc

Browse files
committed
feat: tree-shaking with apollo-client and apollo-client-rxjs
1 parent ca97b30 commit 5d09cbc

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@
3232
},
3333
"peerDependencies": {
3434
"@angular/core": "^2.0.0",
35-
"apollo-client": "^0.5.1",
35+
"apollo-client": "^0.5.25",
3636
"rxjs": "^5.0.0-beta.12 || ^5.0.0-rc.1"
3737
},
3838
"dependencies": {
39-
"apollo-client-rxjs": "~0.2.3"
39+
"apollo-client-rxjs": "~0.2.5"
4040
},
4141
"devDependencies": {
4242
"@angular/common": "^2.3.1",
@@ -51,7 +51,7 @@
5151
"@types/jest": "^15.1.32",
5252
"@types/lodash": "^4.14.34",
5353
"@types/node": "^6.0.38",
54-
"apollo-client": "^0.5.1",
54+
"apollo-client": "^0.5.25",
5555
"ghooks": "^1.3.2",
5656
"graphql-tag": "^1.0.0",
5757
"jest": "^17.0.0",

rollup.config.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ export default {
55
moduleName: 'ng.apollo',
66
globals: {
77
'@angular/core': 'ng.core',
8-
'rxjs/Observable': 'Rx'
8+
'rxjs/Observable': 'Rx',
9+
'rxjs/observable/from': 'Rx.Observable',
10+
'rxjs/observable/fromPromise': 'Rx.Observable',
11+
'apollo-client-rxjs': 'apollo.rxjs',
12+
'apollo-client': 'apollo',
913
}
1014
}

src/Angular2Apollo.ts

+5-6
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,12 @@ import { OpaqueToken, Injectable, Inject } from '@angular/core';
22
import { rxify } from 'apollo-client-rxjs';
33
import { ApolloClient, ApolloQueryResult, WatchQueryOptions, MutationOptions, SubscriptionOptions } from 'apollo-client';
44
import { Observable } from 'rxjs/Observable';
5+
import { from } from 'rxjs/observable/from';
6+
import { fromPromise } from 'rxjs/observable/fromPromise';
57
import { FragmentDefinition } from 'graphql';
68

79
import { ApolloQueryObservable } from './ApolloQueryObservable';
810

9-
import 'rxjs/add/observable/from';
10-
import 'rxjs/add/observable/fromPromise';
11-
1211
export interface DeprecatedWatchQueryOptions extends WatchQueryOptions {
1312
fragments?: FragmentDefinition[];
1413
}
@@ -27,18 +26,18 @@ export class Angular2Apollo {
2726
}
2827

2928
public query(options: DeprecatedWatchQueryOptions): Observable<ApolloQueryResult> {
30-
return Observable.fromPromise(this.client.query(options));
29+
return fromPromise(this.client.query(options));
3130
}
3231

3332
public mutate(options: MutationOptions): Observable<ApolloQueryResult> {
34-
return Observable.fromPromise(this.client.mutate(options));
33+
return fromPromise(this.client.mutate(options));
3534
}
3635

3736
public subscribe(options: SubscriptionOptions): Observable<any> {
3837
if (typeof this.client.subscribe === 'undefined') {
3938
throw new Error(`Your version of ApolloClient doesn't support subscriptions`);
4039
}
4140

42-
return Observable.from(this.client.subscribe(options));
41+
return from(this.client.subscribe(options));
4342
}
4443
}

0 commit comments

Comments
 (0)