Clean up test

Author: ericholscher

readthedocs/rtd_tests/tests/test_domains.py

@@ -82,18 +82,24 @@ def test_https(self):
         self.assertFalse(form.is_valid())
 
     def test_canonical_change(self):
-        """Make sure https is an admin-only attribute"""
+        """Make sure canonical can be properly changed"""
         form = DomainForm({'domain': 'example.com', 'canonical': True},
                           project=self.project)
         self.assertTrue(form.is_valid())
         domain = form.save()
-        self.assertTrue(domain.canonical, 'example.com')
+        self.assertEqual(domain.domain, 'example.com')
 
         form = DomainForm({'domain': 'example2.com', 'canonical': True},
                           project=self.project)
+        self.assertFalse(form.is_valid())
+        self.assertEqual(form.errors['canonical'][0], 'Only 1 Domain can be canonical at a time.')
+
+        form = DomainForm({'domain': 'example2.com', 'canonical': True},
+                          project=self.project,
+                          instance=domain)
         self.assertTrue(form.is_valid())
         domain = form.save()
-        self.assertTrue(domain.canonical, 'example2.com')
+        self.assertEqual(domain.domain, 'example2.com')
 
 
 class TestAPI(TestCase):