Merge branch 'master' of github.com:rtfd/readthedocs.org

* 'master' of github.com:rtfd/readthedocs.org:
  Fix shitpost
  Fix copypasta issue with supervisord config
  Update Build state at the end of UpdateDocsTask.run (readthedocs#3293)

Author: kakulukia

contrib/supervisord.conf

@@ -34,7 +34,7 @@ stderr_logfile = /dev/stderr
 stderr_logfile_maxbytes = 0
 
 [program:celery]
-command = celery worker -A readthedocsinc -Q default,celery,web,builder -l DEBUG -c 2
+command = celery worker -A readthedocs -Q default,celery,web,builder -l DEBUG -c 2
 directory = ../
 priority = 100
 stopasgroup = True

readthedocs/projects/tasks.py

@@ -116,6 +116,7 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,
 
         This is fully wrapped in exception handling to account for a number of failure cases.
         """
+        unhandled_failure = ''
         try:
             self.project = self.get_project(pk)
             self.version = self.get_version(self.project, version_pk)
@@ -128,30 +129,22 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,
             setup_successful = self.run_setup(record=record)
             if setup_successful:
                 self.run_build(record=record, docker=docker)
-            failure = self.setup_env.failure or self.build_env.failure
         except Exception as e:  # noqa
             log.exception(
                 'An unhandled exception was raised outside the build environment',
                 extra={'tags': {'build': build_pk}}
             )
-            failure = _('Unknown error encountered. '
-                        'Please include the build id ({build_id}) in any bug reports.'.format(
-                            build_id=build_pk
-                        ))
-
-        # **Always** report build status.
-        # This can still fail if the API Is totally down, but should catch more failures
-        result = {}
-        build_updates = {'state': BUILD_STATE_FINISHED}
-        build_data = {}
-        if hasattr(self, 'build'):
-            build_data.update(self.build)
-        if failure:
-            build_updates['success'] = False
-            build_updates['error'] = failure
-        build_data.update(build_updates)
-        result = api_v2.build(build_pk).patch(build_updates)
-        return result
+            unhandled_failure = _(
+                'Unknown error encountered. '
+                'Please include the build id ({build_id}) in any bug reports.'.format(
+                    build_id=build_pk
+                ))
+        finally:
+            if unhandled_failure:
+                self.build_env.build['error'] = unhandled_failure
+            self.build_env.update_build(BUILD_STATE_FINISHED)
+
+        return self.build_env.build
 
     def run_setup(self, record=True):
         """Run setup in the local environment.