Skip to content

Commit b271302

Browse files
committed
added labels for namespace and pvc names for a pv
1 parent 0780c82 commit b271302

File tree

2 files changed

+26
-6
lines changed

2 files changed

+26
-6
lines changed

pkg/common/parameters.go

+14-6
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,11 @@ const (
5656
tagKeyCreatedForSnapshotName = "kubernetes.io/created-for/volumesnapshot/name"
5757
tagKeyCreatedForSnapshotNamespace = "kubernetes.io/created-for/volumesnapshot/namespace"
5858
tagKeyCreatedForSnapshotContentName = "kubernetes.io/created-for/volumesnapshotcontent/name"
59+
60+
// Keys for labels to tag to PV
61+
labelKeyCreatedForClaimNamespace = "kubernetes_io_created-for_pvc_namespace"
62+
labelKeyCreatedForClaimName = "kubernetes_io_created-for_pvc_name"
63+
labelKeyCreatedForVolumeName = "kubernetes_io_created-for_pv_name"
5964
)
6065

6166
// DiskParameters contains normalized and defaulted disk parameters
@@ -120,12 +125,15 @@ func ExtractAndDefaultParameters(parameters map[string]string, driverName string
120125
case ParameterKeyDiskEncryptionKmsKey:
121126
// Resource names (e.g. "keyRings", "cryptoKeys", etc.) are case sensitive, so do not change case
122127
p.DiskEncryptionKMSKey = v
123-
case ParameterKeyPVCName:
124-
p.Tags[tagKeyCreatedForClaimName] = v
125-
case ParameterKeyPVCNamespace:
126-
p.Tags[tagKeyCreatedForClaimNamespace] = v
127-
case ParameterKeyPVName:
128-
p.Tags[tagKeyCreatedForVolumeName] = v
128+
case ParameterKeyPVCName:
129+
p.Tags[tagKeyCreatedForClaimName] = v
130+
p.Labels[labelKeyCreatedForClaimName] = v
131+
case ParameterKeyPVCNamespace:
132+
p.Tags[tagKeyCreatedForClaimNamespace] = v
133+
p.Labels[labelKeyCreatedForClaimNamespace] = v
134+
case ParameterKeyPVName:
135+
p.Tags[tagKeyCreatedForVolumeName] = v
136+
p.Labels[labelKeyCreatedForVolumeName] = v
129137
case ParameterKeyLabels:
130138
paramLabels, err := ConvertLabelsStringToMap(v)
131139
if err != nil {

pkg/common/parameters_test.go

+12
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,18 @@ func TestExtractAndDefaultParameters(t *testing.T) {
146146
Labels: map[string]string{"key1": "value1", "label-1": "value-a", "label-2": "label-value-2"},
147147
},
148148
},
149+
{
150+
name: "PVC labels",
151+
parameters: map[string]string{ParameterKeyPVCName: "testPVCName", ParameterKeyPVCNamespace: "testPVCNamespace", ParameterKeyPVName: "testPVName"},
152+
labels: map[string]string{},
153+
expectParams: DiskParameters{
154+
DiskType: "pd-standard",
155+
ReplicationType: "none",
156+
DiskEncryptionKMSKey: "",
157+
Tags: map[string]string{},
158+
Labels: map[string]string{labelKeyCreatedForClaimName: "testPVCName", labelKeyCreatedForClaimNamespace: "testPVCNamespace", labelKeyCreatedForVolumeName: "testPVName"},
159+
},
160+
},
149161
}
150162

151163
for _, tc := range tests {

0 commit comments

Comments
 (0)