Skip to content

Commit 4ab781a

Browse files
author
Alexander Lisianoi
committed
Drop ends-with and object-assign dependencies
1 parent 89138b5 commit 4ab781a

File tree

3 files changed

+8
-15
lines changed

3 files changed

+8
-15
lines changed

index.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,13 @@ var path = require('path')
44
var chalk = require('chalk')
55
var Git = require('git-tools')
66

7-
var endsWith = require('ends-with')
8-
var objectAssign = require('object-assign')
9-
107
var validate = require('./lib/validate')
118
var sanitize = require('./lib/sanitize')
129
var defaults = require('./lib/defaults')
1310

1411
function sliceEnvPath (suffix) {
1512
var p = process.env.PATH.split(':').filter(
16-
function (p) {return endsWith(p, suffix)}
13+
function (p) {return p.endsWith(suffix)}
1714
)
1815

1916
if (p.length === 1) {
@@ -63,7 +60,7 @@ function getOptions () {
6360
pkg = pkg.commitplease || {}
6461
npm = npm.commitplease || {}
6562

66-
var options = objectAssign(pkg, npm)
63+
var options = Object.assign(pkg, npm)
6764

6865
var base = {
6966
'oldMessagePath': defaults.oldMessagePath,
@@ -73,9 +70,9 @@ function getOptions () {
7370
if (options === undefined ||
7471
options.style === undefined ||
7572
options.style === 'jquery') {
76-
return objectAssign(base, defaults.jquery, options)
73+
return Object.assign(base, defaults.jquery, options)
7774
} else if (options.style === 'angular') {
78-
return objectAssign(base, defaults.angular, options)
75+
return Object.assign(base, defaults.angular, options)
7976
}
8077

8178
console.error(chalk.red(

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,8 @@
3636
},
3737
"dependencies": {
3838
"chalk": "^1.1.1",
39-
"ends-with": "^1.0.1",
4039
"git-tools": "^0.2.1",
4140
"ini": "^1.3.4",
42-
"object-assign": "^4.1.0",
4341
"semver": "^5.1.0"
4442
}
4543
}

test.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ var validate = require('./lib/validate')
22
var sanitize = require('./lib/sanitize')
33
var defaults = require('./lib/defaults')
44

5-
var objectAssign = require('object-assign')
6-
75
var jqueryColon =
86
'First line must be <Component>: <subject>\n' +
97
'Missing colon :'
@@ -32,22 +30,22 @@ var jqueryFirstLine72 =
3230

3331
var jquery0 = defaults.jquery
3432

35-
var jquery1 = objectAssign(
33+
var jquery1 = Object.assign(
3634
{}, defaults.jquery, {component: false}
3735
)
3836

39-
var jquery2 = objectAssign(
37+
var jquery2 = Object.assign(
4038
{}, defaults.jquery, {components: ['Build', 'Legacy']}
4139
)
4240

43-
var jquery3 = objectAssign(
41+
var jquery3 = Object.assign(
4442
{}, defaults.jquery, {
4543
markerPattern: '^((clos|fix|resolv)(e[sd]|ing))|^(refs?)',
4644
ticketPattern: '^((Closes|Fixes) ([a-zA-Z]{2,}-)[0-9]+)|^(Refs? [^#])'
4745
}
4846
)
4947

50-
var jquery4 = objectAssign(
48+
var jquery4 = Object.assign(
5149
{}, defaults.jquery, {components: ['^\\[\\w+-\\d+\\]']}
5250
)
5351

0 commit comments

Comments
 (0)