Skip to content

Commit c639531

Browse files
committed
Fix JedisConnectionPipelineIntegrationTests and JedisConnectionTransactionIntegrationTests.
Closes spring-projects#2612
1 parent 8255358 commit c639531

File tree

2 files changed

+23
-15
lines changed

2 files changed

+23
-15
lines changed

src/test/java/org/springframework/data/redis/connection/AbstractConnectionIntegrationTests.java

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2036,7 +2036,7 @@ void testZDiff() {
20362036
actual.add(connection.zAdd("otherset", 4, "James"));
20372037
actual.add(connection.zDiff("myset", "otherset"));
20382038
actual.add(connection.zDiffWithScores("myset", "otherset"));
2039-
verifyResults(Arrays.asList(new Object[] { true, true, true, true, true, Collections.singleton("Joe"),
2039+
verifyResults(Arrays.asList(new Object[] { true, true, true, true, true, Collections.singletonList("Joe"),
20402040
Collections.singleton(new DefaultStringTuple("Joe", 4)) }));
20412041
}
20422042

@@ -2065,9 +2065,10 @@ void testZInter() {
20652065
actual.add(connection.zAdd("otherset", 4, "James"));
20662066
actual.add(connection.zInter("myset", "otherset"));
20672067
actual.add(connection.zInterWithScores("myset", "otherset"));
2068-
verifyResults(Arrays.asList(new Object[] { true, true, true, true, true,
2069-
new LinkedHashSet<>(Arrays.asList("Bob", "James")),
2070-
new LinkedHashSet<>(Arrays.asList(new DefaultStringTuple("Bob", 3d), new DefaultStringTuple("James", 5))) }));
2068+
2069+
verifyResults(Arrays.asList(new Object[] { true, true, true, true, true, Arrays.asList("Bob", "James"),
2070+
new LinkedHashSet<>(Arrays.asList(new DefaultStringTuple("Bob", 3d),
2071+
new DefaultStringTuple("James", 5))) }));
20712072
}
20722073

20732074
@Test // GH-2042
@@ -2082,9 +2083,9 @@ void testZInterAggWeights() {
20822083
actual.add(connection.zInter("myset", "otherset"));
20832084
actual.add(connection.zInterWithScores(Aggregate.MAX, new int[] { 2, 3 }, "myset", "otherset"));
20842085

2085-
verifyResults(Arrays.asList(new Object[] { true, true, true, true, true,
2086-
new LinkedHashSet<>(Arrays.asList("Bob", "James")),
2087-
new LinkedHashSet<>(Arrays.asList(new DefaultStringTuple("Bob", 4d), new DefaultStringTuple("James", 12d))) }));
2086+
verifyResults(Arrays.asList(new Object[] { true, true, true, true, true, Arrays.asList("Bob", "James"),
2087+
new LinkedHashSet<>(Arrays.asList(new DefaultStringTuple("Bob", 4d),
2088+
new DefaultStringTuple("James", 12d))) }));
20882089
}
20892090

20902091
@Test
@@ -2374,15 +2375,16 @@ void testZUnion() {
23742375
actual.add(connection.zAdd("otherset", 4, "James"));
23752376
actual.add(connection.zUnion("myset", "otherset"));
23762377
actual.add(connection.zUnionWithScores("myset", "otherset"));
2377-
verifyResults(Arrays
2378-
.asList(new Object[] { true, true, true, true, true, new LinkedHashSet<>(Arrays.asList("Bob", "James", "Joe")),
2379-
new LinkedHashSet<>(Arrays.asList(new DefaultStringTuple("Bob", 3d), new DefaultStringTuple("James", 5),
2380-
new DefaultStringTuple("Joe", 4))) }));
2378+
2379+
verifyResults(Arrays.asList(new Object[] { true, true, true, true, true, Arrays.asList("Bob", "Joe", "James"),
2380+
new LinkedHashSet<>(Arrays.asList(new DefaultStringTuple("Bob", 3d),
2381+
new DefaultStringTuple("Joe", 4), new DefaultStringTuple("James", 5))) }));
23812382
}
23822383

23832384
@Test // GH-2042
23842385
@EnabledOnCommand("ZUNION")
23852386
void testZUnionAggWeights() {
2387+
23862388
actual.add(connection.zAdd("myset", 2, "Bob"));
23872389
actual.add(connection.zAdd("myset", 1, "James"));
23882390
actual.add(connection.zAdd("myset", 4, "Joe"));
@@ -2391,9 +2393,9 @@ void testZUnionAggWeights() {
23912393
actual.add(connection.zUnion("myset", "otherset"));
23922394
actual.add(connection.zUnionWithScores(Aggregate.MAX, new int[] { 2, 3 }, "myset", "otherset"));
23932395

2394-
verifyResults(Arrays
2395-
.asList(new Object[] { true, true, true, true, true, new LinkedHashSet<>(Arrays.asList("Bob", "James", "Joe")),
2396-
new LinkedHashSet<>(Arrays.asList(new DefaultStringTuple("Bob", 4d), new DefaultStringTuple("Joe", 8d),
2396+
verifyResults(Arrays.asList(new Object[] { true, true, true, true, true, Arrays.asList("Bob", "Joe", "James"),
2397+
new LinkedHashSet<>(Arrays.asList(new DefaultStringTuple("Bob", 4d),
2398+
new DefaultStringTuple("Joe", 8d),
23972399
new DefaultStringTuple("James", 12d))) }));
23982400
}
23992401

src/test/java/org/springframework/data/redis/connection/AbstractConnectionPipelineIntegrationTests.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import java.util.ArrayList;
2222
import java.util.List;
23+
import java.util.stream.IntStream;
2324

2425
import org.junit.jupiter.api.Disabled;
2526
import org.junit.jupiter.api.Test;
@@ -167,12 +168,17 @@ protected void initConnection() {
167168

168169
@Override
169170
protected void verifyResults(List<Object> expected) {
171+
170172
List<Object> expectedPipeline = new ArrayList<>();
171-
for (int i = 0; i < actual.size(); i++) {
173+
174+
for (int index = 0; index < actual.size(); index++) {
172175
expectedPipeline.add(null);
173176
}
177+
174178
assertThat(actual).isEqualTo(expectedPipeline);
179+
175180
List<Object> results = getResults();
181+
176182
assertThat(results).isEqualTo(expected);
177183
}
178184

0 commit comments

Comments
 (0)