fixed spacing, added note about token array representation

Justin Chen · Justin Chen · commit 85925403222b · 2020-07-30T09:45:00.000-07:00
diff --git a/src/PowerShellEditorServices/Services/TextDocument/Handlers/PsesSemanticTokens.cs b/src/PowerShellEditorServices/Services/TextDocument/Handlers/PsesSemanticTokens.cs
@@ -43,7 +43,8 @@ protected override Task Tokenize(SemanticTokensBuilder builder, ITextDocumentIde
             CancellationToken cancellationToken)
         {
             ScriptFile file = _workspaceService.GetFile(DocumentUri.GetFileSystemPath(identifier));
-            foreach (Token token in file.ScriptTokens){
+            foreach (Token token in file.ScriptTokens)
+            {
                 PushToken(token, builder);
             }
             return Task.CompletedTask;
@@ -79,7 +80,8 @@ internal static IEnumerable<SemanticToken> ConvertToSemanticTokens(Token token)
             }
 
             SemanticTokenType mappedType = MapSemanticTokenType(token);
-            if (mappedType == null){
+            if (mappedType == null)
+            {
                 yield break;
             }
 
diff --git a/test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs b/test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs
@@ -1164,7 +1164,7 @@ await PsesLanguageClient
             var expectedArr = new int[5]
                 {
                     // line, index, token length, token type, token modifiers
-                    0, 0, scriptContent.Length, 2, 0 //token 1 is function
+                    0, 0, scriptContent.Length, 2, 0 //function token: line 0, index 0, length, type 2 = keyword, no modifiers
                 };
 
             Assert.Equal(expectedArr, result.Data.ToArray());

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,8 @@ protected override Task Tokenize(SemanticTokensBuilder builder, ITextDocumentIde`
`43`	`43`	`CancellationToken cancellationToken)`
`44`	`44`	`{`
`45`	`45`	`ScriptFile file = _workspaceService.GetFile(DocumentUri.GetFileSystemPath(identifier));`
`46`		`- foreach (Token token in file.ScriptTokens){`
	`46`	`+ foreach (Token token in file.ScriptTokens)`
	`47`	`+ {`
`47`	`48`	`PushToken(token, builder);`
`48`	`49`	`}`
`49`	`50`	`return Task.CompletedTask;`
`@@ -79,7 +80,8 @@ internal static IEnumerable<SemanticToken> ConvertToSemanticTokens(Token token)`
`79`	`80`	`}`
`80`	`81`
`81`	`82`	`SemanticTokenType mappedType = MapSemanticTokenType(token);`
`82`		`- if (mappedType == null){`
	`83`	`+ if (mappedType == null)`
	`84`	`+ {`
`83`	`85`	`yield break;`
`84`	`86`	`}`
`85`	`87`
Original file line number	Diff line number	Diff line change
`@@ -1164,7 +1164,7 @@ await PsesLanguageClient`
`1164`	`1164`	`var expectedArr = new int[5]`
`1165`	`1165`	`{`
`1166`	`1166`	`// line, index, token length, token type, token modifiers`
`1167`		`- 0, 0, scriptContent.Length, 2, 0 //token 1 is function`
	`1167`	`+ 0, 0, scriptContent.Length, 2, 0 //function token: line 0, index 0, length, type 2 = keyword, no modifiers`
`1168`	`1168`	`};`
`1169`	`1169`
`1170`	`1170`	`Assert.Equal(expectedArr, result.Data.ToArray());`