From 34e55182632c1e5c09247481bc9ac8a05544433d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Collonval?= Date: Wed, 23 Feb 2022 12:39:52 +0100 Subject: [PATCH] Fix typing for select and option react components --- packages/react-components/src/option/index.tsx | 2 ++ packages/react-components/src/select/index.tsx | 1 + 2 files changed, 3 insertions(+) diff --git a/packages/react-components/src/option/index.tsx b/packages/react-components/src/option/index.tsx index df86d331..cabda3ff 100644 --- a/packages/react-components/src/option/index.tsx +++ b/packages/react-components/src/option/index.tsx @@ -12,6 +12,8 @@ const { wrap } = provideReactWrapper(React, provideJupyterDesignSystem()); export const Option: React.DetailedHTMLFactory< React.HTMLAttributes & { + checked?: boolean; + defaultSelected?: boolean; disabled?: boolean; selected?: boolean; value?: string; diff --git a/packages/react-components/src/select/index.tsx b/packages/react-components/src/select/index.tsx index 5c84fbff..42f0f47d 100644 --- a/packages/react-components/src/select/index.tsx +++ b/packages/react-components/src/select/index.tsx @@ -16,6 +16,7 @@ export const Select: React.DetailedHTMLFactory< minimal?: boolean; open?: boolean; position?: 'above' | 'below'; + value?: string; }, HTMLElement > = wrap(jpSelect(), {