Skip to content

Tnesorboard needs to have slash (/) on the end of URL #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hadim opened this issue Jul 1, 2018 · 12 comments
Closed

Tnesorboard needs to have slash (/) on the end of URL #41

hadim opened this issue Jul 1, 2018 · 12 comments
Labels

Comments

@hadim
Copy link

hadim commented Jul 1, 2018

The plugin does not seem to work with Tensorboard.

screenshot from 2018-06-30 22-31-27

Can you confirm ?

@hadim
Copy link
Author

hadim commented Jul 1, 2018

Might be fixed with #38

Will try and report here.

@betatim
Copy link
Member

betatim commented Jul 1, 2018

Do you have a repo that is setup with TensorBoard and works on mybinder.org? That would make it easier to debug. Apriori I can't think of a reason why it shouldn't work.

@hadim
Copy link
Author

hadim commented Jul 1, 2018

The PR does not fix it.

On binder, I got a 404 error. Bu locally the Tensorboard UI load and then stop (probably because of some 404 errors, see the screenshots for details).

@betatim
Copy link
Member

betatim commented Jul 1, 2018

As far as I can tell from your repo you don't activate the notebook server extension. The last bit of the README after the bit about using conda to install stuff.

@hadim
Copy link
Author

hadim commented Jul 1, 2018

My bad I forgot the enable the extension.

I tried to add the postBuild file but the extension does not seem to load... I must be missing something obvious: https://github.com/hadim/binder-test/blob/master/postBuid

@hadim
Copy link
Author

hadim commented Jul 1, 2018

My bad again postBuild filename was misspelt... I can now reproduce the issue: https://mybinder.org/v2/gh/hadim/binder-test/master?urlpath=lab

@betatim
Copy link
Member

betatim commented Jul 1, 2018

If I launch your binder and then visit https://hub.mybinder.org/user/hadim-binder-test-/proxy/6006 I see the output of tensorboard. I think this means it works?

Should we close this issue?

@hadim
Copy link
Author

hadim commented Jul 1, 2018

Yes, Tensoboard interface shows up but if you open your browser console, you'll see a lot of 404 errors. I think Tensorboard is using WebSocket or something else to communicate with the server and retrieve info.

To better illustrate the issue have added a notebook to the repo called TF_Example.ipynb: https://mybinder.org/v2/gh/hadim/binder-test/master?urlpath=lab

If you execute the notebook and then launch tensorboard --logdir=/tmp/tensorflow_logs in a terminal when you visit https://hub.mybinder.org/user/hadim-binder-test-/proxy/6006, you should see a message Failed to load the set of active dashboards.

Without the proxy and locally I see TF scalar values and the TF graph:

screenshot from 2018-07-01 16-39-52

screenshot from 2018-07-01 16-40-01

@betatim
Copy link
Member

betatim commented Jul 3, 2018

Thanks for the instructions. When I run it and look at the network requests being made I see lots of requests to https://hub.mybinder.org/user/hadim-binder-test-UNIQUE/proxy/data/runs which result in 404 errors. Not sure why tensor board cuts off the port number. Maybe it has a baseUrl configuration option or something like that?

If you manually try out https://hub.mybinder.org/user/hadim-binder-test-UNIQUE/proxy/6006/data/runs (with port) you get a JSON response. So I think this is something about configuring tensorboard.

@hadim
Copy link
Author

hadim commented Jul 3, 2018

Thank you @betatim. I think you got the cause of the issue correctly. Unfortunately after trying a bunch of --path_prefix, --base_url and --host options, I can't get it to work.

I'll open an issue on the TB repo.

Thanks for the help.

@hadim
Copy link
Author

hadim commented Jul 3, 2018

Easy fix: add a trailing slash at the end of the URL.

@hadim hadim closed this as completed Jul 3, 2018
@betatim
Copy link
Member

betatim commented Jul 4, 2018

"Easy" :) Only took two people several hours to work out :-/

Thanks for making the examples for reproducing this and for figuring it out in the end!

I updated the title to try and make it so others with similar problems will find it, not just tensorboard users.

@betatim betatim changed the title Does it work with Tensorboard? Tnesorboard needs to have slash (/) on the end of URL Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants