Skip to content

Commit 2a83343

Browse files
committed
Fix error generation
1 parent f547e5f commit 2a83343

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

jupyter_server_proxy/standalone/proxy.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from jupyterhub.utils import make_ssl_context
1010
from tornado import httpclient, web
1111
from tornado.log import app_log
12-
from tornado.web import Application, RedirectHandler
12+
from tornado.web import Application, RedirectHandler, RequestHandler
1313
from tornado.websocket import WebSocketHandler
1414

1515
from ..handlers import SuperviseAndProxyHandler
@@ -49,6 +49,14 @@ def set_default_headers(self):
4949
def prepare(self, *args, **kwargs):
5050
pass
5151

52+
def check_origin(self, origin: str = None):
53+
# Skip JupyterHandler.check_origin
54+
return WebSocketHandler.check_origin(self, origin)
55+
56+
def write_error(self, status_code: int, **kwargs):
57+
# ToDo: Return proper error page, like in jupyter-server/JupyterHub
58+
return RequestHandler.write_error(self, status_code, **kwargs)
59+
5260
async def proxy(self, port, path):
5361
if self.skip_authentication:
5462
return await super().proxy(port, path)
@@ -59,10 +67,6 @@ async def proxy(self, port, path):
5967
async def oauth_proxy(self, port, path):
6068
return await super().proxy(port, path)
6169

62-
def check_origin(self, origin: str = None):
63-
# Skip JupyterHandler.check_origin
64-
return WebSocketHandler.check_origin(self, origin)
65-
6670
def get_env(self):
6771
return self._render_template(self.environment)
6872

0 commit comments

Comments
 (0)