Skip to content

Update warning message ip address #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willingc opened this issue Sep 21, 2016 · 1 comment
Closed

Update warning message ip address #78

willingc opened this issue Sep 21, 2016 · 1 comment

Comments

@willingc
Copy link
Contributor

In https://github.com/jupyterhub/configurable-http-proxy/blob/master/bin/configurable-http-proxy#L216, we caution against using '*' as an ip in the docs and in the warning a few lines above yet it is displayed by L216. Perhaps change to '0.0.0.0' or '' or emit a warning such a few lines above.

@minrk
Copy link
Member

minrk commented Sep 22, 2016

There's an ever-so-slight difference between '' and 0.0.0.0, where '' is all interfaces, while 0.0.0.0 is all IPv4 interfaces. This will make a difference approximately never, but we could use the text "all interfaces" when ip is blank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants