Skip to content

Update to jasmine >= 4 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guimard opened this issue Mar 29, 2022 · 1 comment
Closed

Update to jasmine >= 4 #386

guimard opened this issue Mar 29, 2022 · 1 comment
Labels

Comments

@guimard
Copy link

guimard commented Mar 29, 2022

Hi,

for the record, here is a fix to update to jasmine >= 4 (used to publish configurable-http-proxy into Debian):

--- a/prom-client/test/metrics/eventLoopLagTest.js
+++ b/prom-client/test/metrics/eventLoopLagTest.js
@@ -12,11 +12,11 @@
                register.clear();
        });
   
-       it('should add metric to the registry', async done => {
+       it('should add metric to the registry', async () => {
                expect(await register.getMetricsAsJSON()).toHaveLength(0);
                eventLoopLag();
 
-               setTimeout(async () => {
+               setTimeout(async (done) => {
                        const metrics = await register.getMetricsAsJSON();
                        expect(metrics).toHaveLength(8);

Cheers,
Yadd

@guimard guimard added the bug label Mar 29, 2022
@guimard guimard changed the title Update to jest >= 27 Update to jasmine >= 4 Mar 29, 2022
@consideRatio
Copy link
Member

consideRatio commented Jun 20, 2022

This is a fix for prom-client rather than this project, but we can bump to jasmine no matter what if we drop support for node 10 which is about time anyhow.

Thanks for the detailed fix suggestion, but should be done in prom-client I think. Bumping jasmine to 4 can be tracked in #402

Thank you @guimard!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants