Skip to content

Require Node 12 (at least 10) #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
consideRatio opened this issue Jun 3, 2021 · 1 comment · Fixed by #323
Closed

Require Node 12 (at least 10) #322

consideRatio opened this issue Jun 3, 2021 · 1 comment · Fixed by #323
Labels

Comments

@consideRatio
Copy link
Member

consideRatio commented Jun 3, 2021

We specify that node >=6 is required, but in practice we test only against 10+ where tests are flaky on node 10.

Node 10 is no longer actively maintained, only node 12+ is under active maintenance at the moment. I suggest we bump our requirement from node >= 6 to node >= 12.

@minrk and @manics what do you think? I believe our outdated specification of this relates to several issues we have run into in the past about TLS matters and now more recently perhaps also #321. Do you agree to require node >= 12?

"engines": {
"node": ">= 6.0"
},

@consideRatio consideRatio changed the title Require Node 12 or at least 10 Require Node 12 (at least 10) Jun 3, 2021
@consideRatio
Copy link
Member Author

This did in fact solve another issue, i'll open a PR unless someone beats me to it (currently on mobile)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant