Skip to content

Making a release #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
consideRatio opened this issue Nov 12, 2019 · 5 comments
Closed

Making a release #219

consideRatio opened this issue Nov 12, 2019 · 5 comments

Comments

@consideRatio
Copy link
Member

consideRatio commented Nov 12, 2019

I'd be very happy to see a release of CHP for z2jh to use. It would allow the z2jh proxy pod to snappily restart following #217 and also allowing the hub pod to become ready a lot quicker without erroring. The hub pod will crash with error unless it has successfully communicated with a running proxy pod that is slow to restart for example.

I'd happily put in some effort here, but could use some initial guidance, approval to work toward making a release, and considerations to have in mind etc.

@minrk
Copy link
Member

minrk commented Nov 12, 2019

Let's add it! Releasing CHP is the same as ~any npm package:

npm version $VERSION
npm publish
git push --tags

You need an npm account and I can give you access.

@consideRatio
Copy link
Member Author

Deal okay I'll learn about that then, I have no experienced on that ;)

Push a git tag, build and pusha a docker image, build and publish the npm package. @minrk I created an account called consideratio on npmjs.

I note that the :latest docker image tag on dockerhub was updated, but the Docker image tag 4.1.0 was pushed 7 months ago.

@minrk
Copy link
Member

minrk commented Nov 13, 2019

Docker images are tagged and built automatically on docker hub, so should be no need to do anything there. I think those three lines are literally everything in making a release, assuming changelog, etc. are up to date. I've given you write access to the package on npm, so you should be able to publish the next release!

@consideRatio
Copy link
Member Author

A release is made now! :)

@minrk
Copy link
Member

minrk commented Nov 14, 2019

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants