Skip to content

Command line option for custom headers #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ivan-gomes opened this issue Jun 3, 2019 · 0 comments · Fixed by #206
Closed

Command line option for custom headers #205

ivan-gomes opened this issue Jun 3, 2019 · 0 comments · Fixed by #206

Comments

@ivan-gomes
Copy link
Contributor

ivan-gomes commented Jun 3, 2019

configurable-http-proxy supports a wide range of configuration options, but it is not practical for it to cover all use cases. An example of an uncovered use case is the Strict-Transport-Security response header. Instead of adding yet another configuration option specifically for this header I propose we implement a --custom-headers <headers> configuration option that allows for user-specified headers to be added to all proxied requests. Upstream projects like https://github.com/jupyterhub/zero-to-jupyterhub-k8s can expose the option to be passed to configurable-http-proxy, for example through the Helm chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant