Add tests

Author: dtaniwaki

bin/configurable-http-proxy

@@ -342,12 +342,7 @@ log.info(
   listen.apiPort
 );
 if (listen.metricsPort) {
-  log.info(
-    "Serve metrics at %s://%s:%s/metrics",
-    "http",
-    listen.metricsIp,
-    listen.metricsPort
-  );
+  log.info("Serve metrics at %s://%s:%s/metrics", "http", listen.metricsIp, listen.metricsPort);
 }
 
 if (args.pidFile) {

lib/testutil.js

@@ -128,12 +128,18 @@ exports.setupProxy = function (port, options, paths) {
 
   servers.push(proxy.apiServer);
   servers.push(proxy.proxyServer);
+  if (options.enableMetrics) {
+    servers.push(proxy.metricsServer);
+  }
   proxy.apiServer.on("listening", onlisten);
   proxy.proxyServer.on("listening", onlisten);
 
   addTargets(proxy, paths || ["/"], port + 2).then(function () {
     proxy.proxyServer.listen(port, ip);
     proxy.apiServer.listen(port + 1, ip);
+    if (options.enableMetrics) {
+      proxy.metricsServer.listen(port + 3, ip);
+    }
   });
   return p;
 };

test/api_spec.js

@@ -13,7 +13,6 @@ describe("API Tests", function () {
   var apiPort = port + 1;
   var proxy;
   var apiUrl = "http://127.0.0.1:" + apiPort + "/api/routes";
-  var metricsUrl = "http://127.0.0.1:" + apiPort + "/metrics";
 
   var r;
 
@@ -261,21 +260,4 @@ describe("API Tests", function () {
       .then(() => doReq(0))
       .then();
   });
-
-  it("GET /metrics", function (done) {
-    r(metricsUrl).then((body) => {
-      expect(body).toContain("process_cpu_user_seconds_total");
-      done();
-    });
-  });
-
-  it("GET /metrics (disabled)", function (done) {
-    proxy.options.disableMetrics = true;
-    r(metricsUrl)
-      .then((body) => done.fail("Expected 404"))
-      .catch((error) => {
-        expect(error.statusCode).toEqual(404);
-      })
-      .then(done);
-  });
 });