Skip to content

Commit 8347036

Browse files
authored
Merge pull request #349 from minrk/back-to-node-10
Restore node 10 as base supported engine
2 parents ba0c85d + 4bdd5ad commit 8347036

File tree

4 files changed

+2630
-18
lines changed

4 files changed

+2630
-18
lines changed

.github/workflows/test.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,13 @@ jobs:
6060
strategy:
6161
fail-fast: false # Do not cancel all jobs if one fails
6262
matrix:
63-
# IMPORTANT: Make sure to update package.json's enginges.node field to
63+
# IMPORTANT: Make sure to update package.json's engines.node field to
6464
# always require at least the oldest version, as well as our
6565
# README.md file under the install section.
6666
node_version:
67-
- "12" # Remove 2022-04-30, its end-of-life.
67+
# Removing node 10 is dropping support for ubuntu 20.04 LTS
68+
- "10"
69+
- "12"
6870
- "14"
6971
- "15" # Remove about when 17 is available?
7072
- "16"

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ functionality to [JupyterHub] deployments.
3434

3535
## Install
3636

37-
Prerequisite: [Node.js](https://nodejs.org/en/download/)12
37+
Prerequisite: [Node.js](https://nodejs.org/en/download/)10
3838

3939
If you're installing `configurable-http-proxy` in Linux, you can follow [the instruction of nodesource](https://github.com/nodesource/distributions#installation-instructions) to install arbitrary version of Node.js.
4040

0 commit comments

Comments
 (0)