need separate agent for http/https

Author: minrk

lib/configproxy.js

@@ -173,7 +173,6 @@ class ConfigurableProxy extends EventEmitter {
       });
     }
     options.ws = true;
-    this.agent = options.agent = new http.Agent({ keepAlive: true });
     var proxy = (this.proxy = httpProxy.createProxyServer(options));
 
     // tornado-style regex routing,
@@ -220,9 +219,14 @@ class ConfigurableProxy extends EventEmitter {
       this.metricsServer = http.createServer(metricsCallback);
     }
 
+    // need separate agents for http and https requests
+    // these agents allow our _upstream_ sockets to be kept alive
+    this.httpAgent = http.globalAgent = new http.Agent({ keepAlive: true });
+    this.httpsAgent = https.globalAgent = new https.Agent({ keepAlive: true });
+
+    // these settings configure requests to the proxy itself to accept keep-alive
     var httpOptions = {
       keepAlive: true,
-      agent: this.agent,
       keepAliveTimeout: this.options.keepAliveTimeout || 5000,
     };
 
@@ -560,7 +564,13 @@ class ConfigurableProxy extends EventEmitter {
         }
 
         // add config argument
-        args.push({ target: target });
+        var proxyOptions = { target: target };
+        if (target.protocol.slice(-2) === "s:") {
+          proxyOptions.agent = that.httpsAgent;
+        } else {
+          proxyOptions.agent = that.httpAgent;
+        }
+        args.push(proxyOptions);
 
         // add error handling
         args.push(function (e) {