From b41067fa9347c55d30821f3e3a85c01aab1726e9 Mon Sep 17 00:00:00 2001 From: Vidar Tonaas Fauske Date: Thu, 10 Oct 2024 16:48:16 +0100 Subject: [PATCH] Fix Euler deserialization Previously it lower-cased these strings, and three docs (and our traits) says they should be upper case. --- js/src/_base/Three.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/js/src/_base/Three.js b/js/src/_base/Three.js index 10a260c2..bc5ef779 100644 --- a/js/src/_base/Three.js +++ b/js/src/_base/Three.js @@ -568,8 +568,7 @@ class ThreeModel extends widgets.WidgetModel { // Euler convertEulerModelToThree(v) { - // The float conversions will ignore the "XYZ" order strings - return new THREE.Euler().fromArray(v.map(this.convertFloatModelToThree)); + return new THREE.Euler().fromArray(v.map((e, i) => i < 3 ? this.convertFloatModelToThree(e) : e)); } convertEulerThreeToModel(v) {