Skip to content

Examples: radialSegments -> radiusSegments #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wstomv opened this issue Mar 16, 2019 · 2 comments · Fixed by #253
Closed

Examples: radialSegments -> radiusSegments #251

wstomv opened this issue Mar 16, 2019 · 2 comments · Fixed by #253

Comments

@wstomv
Copy link

wstomv commented Mar 16, 2019 •
edited
Loading

In

pythreejs/examples/Geometries.ipynb

Line 173 in 952ab13

" radialSegments=6, \n",
and other places, radialSegments appears, but this should be radiusSegments.
@vidartf
Copy link
Member

vidartf commented Mar 19, 2019

Thanks for the report! There is definitely an error here, but the three.js docs/code should be considered the source of truth here. I'll add this to #253 shortly!

@vidartf
Copy link
Member

vidartf commented Mar 19, 2019

Xref: mrdoob/three.js#13509

@vidartf vidartf mentioned this issue Mar 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add EdgesGeometry definition vidartf/pythreejs
2 participants
@vidartf @wstomv