Skip to content

Commit 62fddb0

Browse files
committed
radiusSegments -> radialSegments
1 parent 53cc733 commit 62fddb0

File tree

5 files changed

+21
-33
lines changed

5 files changed

+21
-33
lines changed

examples/Animation.ipynb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2225,7 +2225,7 @@
22252225
"heightSegments": 15,
22262226
"openEnded": true,
22272227
"radiusBottom": 5,
2228-
"radiusSegments": 5,
2228+
"radialSegments": 5,
22292229
"radiusTop": 5
22302230
}
22312231
},

examples/Geometries.ipynb

+5-3
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@
158158
"version_minor": 0
159159
},
160160
"text/plain": [
161-
"Preview(child=CylinderGeometry(height=15.0, heightSegments=10, radiusBottom=10.0, radiusTop=5.0), shadowMap=We"
161+
"Preview(child=CylinderGeometry(height=15.0, heightSegments=10, radialSegments=6, radiusBottom=10.0, radiusTop=…"
162162
]
163163
},
164164
"metadata": {},
@@ -190,7 +190,7 @@
190190
"version_minor": 0
191191
},
192192
"text/plain": [
193-
"Preview(child=CylinderBufferGeometry(height=15.0, heightSegments=10, radiusBottom=10.0, radiusTop=5.0), shadow"
193+
"Preview(child=CylinderBufferGeometry(height=15.0, heightSegments=10, radialSegments=6, radiusBottom=10.0, radi"
194194
]
195195
},
196196
"metadata": {},
@@ -741,7 +741,7 @@
741741
" path=None,\n",
742742
" segments=64,\n",
743743
" radius=1,\n",
744-
" radiusSegments=8,\n",
744+
" radialSegments=8,\n",
745745
" close=False)"
746746
]
747747
},
@@ -974,6 +974,7 @@
974974
"_view_module_version": "",
975975
"height": 15,
976976
"heightSegments": 10,
977+
"radialSegments": 6,
977978
"radiusBottom": 10,
978979
"radiusTop": 5
979980
}
@@ -1013,6 +1014,7 @@
10131014
"_view_module_version": "",
10141015
"height": 15,
10151016
"heightSegments": 10,
1017+
"radialSegments": 6,
10161018
"radiusBottom": 10,
10171019
"radiusTop": 5
10181020
}

js/package-lock.json

+7-21
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/scripts/three-class-config.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -1511,12 +1511,12 @@ module.exports = {
15111511
CylinderBufferGeometry: {
15121512
relativePath: './geometries/CylinderGeometry',
15131513
superClass: 'BaseBufferGeometry',
1514-
constructorArgs: [ 'radiusTop', 'radiusBottom', 'height', 'radiusSegments', 'heightSegments', 'openEnded', 'thetaStart', 'thetaLength' ],
1514+
constructorArgs: [ 'radiusTop', 'radiusBottom', 'height', 'radialSegments', 'heightSegments', 'openEnded', 'thetaStart', 'thetaLength' ],
15151515
properties: {
15161516
radiusTop: new Types.Float(1.0),
15171517
radiusBottom: new Types.Float(1.0),
15181518
height: new Types.Float(1.0),
1519-
radiusSegments: new Types.Int(8),
1519+
radialSegments: new Types.Int(8),
15201520
heightSegments: new Types.Int(1),
15211521
openEnded: new Types.Bool(false),
15221522
thetaStart: new Types.Float(0.0),
@@ -1526,12 +1526,12 @@ module.exports = {
15261526
CylinderGeometry: {
15271527
relativePath: './geometries/CylinderGeometry',
15281528
superClass: 'BaseGeometry',
1529-
constructorArgs: [ 'radiusTop', 'radiusBottom', 'height', 'radiusSegments', 'heightSegments', 'openEnded', 'thetaStart', 'thetaLength' ],
1529+
constructorArgs: [ 'radiusTop', 'radiusBottom', 'height', 'radialSegments', 'heightSegments', 'openEnded', 'thetaStart', 'thetaLength' ],
15301530
properties: {
15311531
radiusTop: new Types.Float(1.0),
15321532
radiusBottom: new Types.Float(1.0),
15331533
height: new Types.Float(1.0),
1534-
radiusSegments: new Types.Int(8),
1534+
radialSegments: new Types.Int(8),
15351535
heightSegments: new Types.Int(1),
15361536
openEnded: new Types.Bool(false),
15371537
thetaStart: new Types.Float(0.0),
@@ -1798,12 +1798,12 @@ module.exports = {
17981798
TubeGeometry: {
17991799
relativePath: './geometries/TubeGeometry',
18001800
superClass: 'BaseGeometry',
1801-
constructorArgs: [ 'path', 'segments', 'radius', 'radiusSegments', 'close' ],
1801+
constructorArgs: [ 'path', 'segments', 'radius', 'radialSegments', 'close' ],
18021802
properties: {
18031803
path: new Types.ThreeType('Curve'),
18041804
segments: new Types.Int(64),
18051805
radius: new Types.Float(1.0),
1806-
radiusSegments: new Types.Int(8),
1806+
radialSegments: new Types.Int(8),
18071807
close: new Types.Bool(false),
18081808
},
18091809
},

pythreejs/sage.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def json_cone(t):
7272
return CylinderGeometry(radiusTop=0,
7373
radiusBottom=t['bottomradius'],
7474
height=t['height'],
75-
radiusSegments=50)
75+
radialSegments=50)
7676

7777
def json_cylinder(t):
7878
return CylinderGeometry(radiusTop=t['radius'],
@@ -99,7 +99,7 @@ def json_line(t):
9999
radiusBottom=.02*tree_geometry['thickness'],
100100
height=height,
101101
up=[1,0,0],
102-
radiusSegments=50))
102+
radialSegments=50))
103103
c.look_at(path[-1], path[-2])
104104
q1 = c.quaternion
105105
q2 = [0.7071067811865475, 0.0, 0.0, 0.7071067811865476]

0 commit comments

Comments
 (0)