Skip to content

Commit e07e35f

Browse files
chore: update pre-commit hooks (#1427)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <[email protected]>
1 parent 21332f4 commit e07e35f

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

.pre-commit-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ repos:
2121
- id: trailing-whitespace
2222

2323
- repo: https://github.com/python-jsonschema/check-jsonschema
24-
rev: 0.28.2
24+
rev: 0.28.4
2525
hooks:
2626
- id: check-github-workflows
2727

@@ -39,7 +39,7 @@ repos:
3939
types_or: [yaml, html, json]
4040

4141
- repo: https://github.com/codespell-project/codespell
42-
rev: "v2.2.6"
42+
rev: "v2.3.0"
4343
hooks:
4444
- id: codespell
4545
args: ["-L", "sur,nd"]
@@ -61,7 +61,7 @@ repos:
6161
["traitlets>=5.13", "jupyter_core>=5.5", "jupyter_client>=8.5"]
6262

6363
- repo: https://github.com/astral-sh/ruff-pre-commit
64-
rev: v0.4.3
64+
rev: v0.4.7
6565
hooks:
6666
- id: ruff
6767
types_or: [python, jupyter]

jupyter_server/services/contents/fileio.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ class FileManagerMixin(LoggingConfigurable, Configurable):
191191
use_atomic_writing = Bool(
192192
True,
193193
config=True,
194-
help="""By default notebooks are saved on disk on a temporary file and then if succefully written, it replaces the old ones.
194+
help="""By default notebooks are saved on disk on a temporary file and then if successfully written, it replaces the old ones.
195195
This procedure, namely 'atomic_writing', causes some bugs on file system without operation order enforcement (like some networked fs).
196196
If set to False, the new notebook is written directly on the old one which could fail (eg: full filesystem or quota )""",
197197
)

jupyter_server/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import socket
1111
import sys
1212
import warnings
13+
from _frozen_importlib_external import _NamespacePath
1314
from contextlib import contextmanager
1415
from pathlib import Path
1516
from typing import Any, Generator, NewType, Sequence
@@ -26,7 +27,6 @@
2627
)
2728
from urllib.request import pathname2url as _pathname2url
2829

29-
from _frozen_importlib_external import _NamespacePath
3030
from jupyter_core.utils import ensure_async as _ensure_async
3131
from packaging.version import Version
3232
from tornado.httpclient import AsyncHTTPClient, HTTPClient, HTTPRequest, HTTPResponse

tests/test_files.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,5 +225,5 @@ async def test_old_files_redirect(jp_fetch, jp_serverapp, jp_root_dir):
225225

226226
# r = self.request('GET', 'files/test.txt?download=1')
227227
# disposition = r.headers.get('Content-Disposition', '')
228-
# self.assertIn('attachment', disposition)
229-
# self.assertIn("filename*=utf-8''test.txt", disposition)
228+
# assert 'attachment' in disposition
229+
# assert "filename*=utf-8''test.txt" in disposition

0 commit comments

Comments
 (0)